Fix the creation of a native environment on MacOS (#79) #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Clang is the default compiler on MacOS, so "icecc --build-native"
should default to build a Clang toolchain on MacOS.
* Fix on icecc-create-env the detection of the path for gcc.
| @@ -60,6 +60,7 @@ | |||
| #include <sys/wait.h> | |||
|
|
|||
| #include "client.h" | |||
| #include "platform.h" | |||
There was a problem hiding this comment.
I don't have neither platform.h nor determine_platform on linux
There was a problem hiding this comment.
On 12/02/15 14:28, Stephan Kulow wrote:
@@ -60,6 +60,7 @@
#include <sys/wait.h>#include "client.h"
+#include "platform.h"I don't have neither platform.h nor determine_platform on linux
Reply to this email directly or view it on GitHub:
https://github.com/icecc/icecream/pull/118/files#r24579917
platform.h is services/platform.h
I tested it on Linux, works fine.
??
|
that happens if you visit code only once a year :) |
coolo
added a commit
that referenced
this pull request
Feb 12, 2015
Fix the creation of a native environment on MacOS (#79)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should default to build a Clang toolchain on MacOS.