test: verify Docker image builds and starts successfully with default and custom port#337
test: verify Docker image builds and starts successfully with default and custom port#337icebear0828 wants to merge 1 commit intomasterfrom
Conversation
… and custom port This updates the CI workflow to run the Docker smoke test across a port matrix (8080 and 8090). It also updates `docker-healthcheck.sh` to check the `PORT` environment variable before reading configuration files to ensure the healthcheck properly evaluates custom ports provided to `docker run`. Co-authored-by: icebear0828 <63769498+icebear0828@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Fixes #120
.github/workflows/ci-docker.ymlto use a strategy matrix forport: [8080, 8090].smoke-testcontainer to use the dynamicmatrix.port.docker-healthcheck.shto first resolve the port using thePORTenvironment variable before falling back tolocal.yamlordefault.yaml.PR created automatically by Jules for task 10567512417294646199 started by @icebear0828