fix: handle SIGTERM for graceful shutdown on system shutdown/logout#335
Merged
icebear0828 merged 1 commit intomasterfrom Apr 8, 2026
Merged
fix: handle SIGTERM for graceful shutdown on system shutdown/logout#335icebear0828 merged 1 commit intomasterfrom
icebear0828 merged 1 commit intomasterfrom
Conversation
Without this, before-quit intercepts OS-initiated termination (system
shutdown, logout), causing macOS to wait then SIGKILL the process.
process.on('SIGTERM') calls quitApplication() which sets allowProcessExit
synchronously before before-quit fires, enabling graceful server cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #324.
Problem
before-quitintercepts all quit events on macOS (event.preventDefault()), including OS-initiated ones (system shutdown, logout). macOS sends SIGTERM, Electron converts it toapp.quit()→before-quit, butallowProcessExitis stillfalse→ event is blocked. macOS waits ~5s then SIGKILL.Fix
quitApplication()setsallowProcessExit = truesynchronously. Sincebefore-quitis dispatched as a Chromium task (asynchronous), the flag is set beforebefore-quitfires — server gets a graceful cleanup window before exit.Test plan
npm testpasses