Skip to content

test: verify Docker image builds and starts successfully#326

Open
icebear0828 wants to merge 1 commit intomasterfrom
ci-docker-smoke-test-matrix-17754268599624577203
Open

test: verify Docker image builds and starts successfully#326
icebear0828 wants to merge 1 commit intomasterfrom
ci-docker-smoke-test-matrix-17754268599624577203

Conversation

@icebear0828
Copy link
Copy Markdown
Owner

This PR resolves issue #120 by introducing a matrix strategy to .github/workflows/ci-docker.yml to test the Docker container on both the default port (8080) and a custom overridden port (8090).

Changes:

  • Updated ci-docker.yml with a strategy.matrix configuration [8080, 8090].
  • Mapped docker run to the matrix port via -p and injected the -e PORT environment variable.
  • Generated a local.yaml file on the fly with the port configuration to mount as a volume, effectively testing the configuration override loading flow.
  • Refactored docker-healthcheck.sh to correctly resolve the listening port from the PORT env variable, the local.yaml overlay, or the default config, ensuring the internal healthcheck passes when the container is run on non-default ports.

PR created automatically by Jules for task 17754268599624577203 started by @icebear0828

Fixes #120

Co-authored-by: icebear0828 <63769498+icebear0828@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant