Skip to content

test: add electron launch smoke test#317

Open
icebear0828 wants to merge 1 commit intomasterfrom
feat/electron-smoke-test-4080358255403475170
Open

test: add electron launch smoke test#317
icebear0828 wants to merge 1 commit intomasterfrom
feat/electron-smoke-test-4080358255403475170

Conversation

@icebear0828
Copy link
Copy Markdown
Owner

Fixes #121

This PR implements the requested Electron launch smoke test to verify the application bundles correctly and the main window opens without errors.

Changes:

  • Added Playwright dependencies to the packages/electron workspace.
  • Implemented packages/electron/__tests__/launch.test.ts using @playwright/test _electron.launch API.
  • The test verifies the window successfully spawns and isn't crashed.
  • It bypasses the native transport requirement (which usually crashes headless instances on CI) by injecting local overrides into a temporary user data dir.
  • Added a new GitHub Actions workflow .github/workflows/test-electron.yml that checks out the code, builds all components (web, native, typescript, esbuild), unpacks via electron-builder, and runs the new smoke test via xvfb-run on Ubuntu.

PR created automatically by Jules for task 4080358255403475170 started by @icebear0828

Adds a Playwright E2E smoke test to verify the Electron application builds, launches, and does not crash on startup. Also configures a GitHub Actions workflow to run this test automatically in CI using `xvfb-run`.

Co-authored-by: icebear0828 <63769498+icebear0828@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: verify Electron app packages and launches

1 participant