Conversation
Addresses #121. Adds an isolated E2E smoke test using Playwright and Vitest that verifies the Electron application can successfully build, package (via electron-builder), and launch without crashing. - Added `@playwright/test` and `playwright` to `@codex-proxy/electron` devDependencies. - Created `packages/electron/__tests__/smoke.test.ts`. - Bypasses native transport errors during testing using `local.yaml` and `DISABLE_NATIVE_TRANSPORT=1`. - Conditionally executed via `process.env.CI || process.env.RUN_E2E_SMOKE` to avoid local test suite pollution. - Proper cleanup of temporary Chromium user data directories. Co-authored-by: icebear0828 <63769498+icebear0828@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This pull request introduces a smoke test to ensure the Electron app successfully builds, packages, and launches without crashing, addressing the requirements outlined in #121.
The changes involve:
@playwright/testandplaywrightas development dependencies in thepackages/electronworkspace.packages/electron/__tests__/smoke.test.tsusing Vitest and Playwright. The test:esbuildandelectron-builderto verify the build process.describe.runIfto prevent it from polluting standard unit test executions by requiring explicitly set environment variables (CIorRUN_E2E_SMOKE), thus resolving the local DX degradation issue.codex-tls) loading errors during testing by generating a temporarylocal.yamloverlay configuring thecurl-clitransport and executing withDISABLE_NATIVE_TRANSPORT=1.PR created automatically by Jules for task 17712378451594297203 started by @icebear0828