Skip to content

test: verify Docker image builds and starts successfully with custom ports#290

Open
icebear0828 wants to merge 1 commit intomasterfrom
test-ci-docker-8266443933047342907
Open

test: verify Docker image builds and starts successfully with custom ports#290
icebear0828 wants to merge 1 commit intomasterfrom
test-ci-docker-8266443933047342907

Conversation

@icebear0828
Copy link
Copy Markdown
Owner

This implements a CI smoke test in the existing GitHub Actions workflow (.github/workflows/ci-docker.yml) that verifies the Docker image can build and start successfully.

Changes:

  • Replaced the single smoke job with a strategy.matrix to test ports 8080 and 8090.
  • Added logic to generate a custom config_override/default.yaml to override the application's configuration when running on the custom port.
  • Updated the docker run command to map the correct ports and mount the custom YAML configuration.
  • Shortened the wait-for-healthcheck polling loop to wait up to 30 seconds (30 attempts at 1-second intervals).
  • Updated the /health and /v1/models curl commands to dynamically fetch from ${{ matrix.port }}.
  • Ensured proper resource cleanup at the end.

PR created automatically by Jules for task 8266443933047342907 started by @icebear0828

…ports

Updates the .github/workflows/ci-docker.yml to use a strategy matrix testing both port 8080 and 8090. Includes proper overriding of config/default.yaml for the custom port, asserts healthy Docker startup up to 30 seconds, and verifies both /health and /v1/models endpoints via cURL.

Co-authored-by: icebear0828 <63769498+icebear0828@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant