Skip to content

test: verify Docker image builds and starts successfully with custom ports#273

Open
icebear0828 wants to merge 1 commit intomasterfrom
ci-docker-smoke-test-custom-port-1672490460434658714
Open

test: verify Docker image builds and starts successfully with custom ports#273
icebear0828 wants to merge 1 commit intomasterfrom
ci-docker-smoke-test-custom-port-1672490460434658714

Conversation

@icebear0828
Copy link
Copy Markdown
Owner

Fixes #120

Changes Made

  • Added a step to dynamically generate a custom default.yaml setting the server.port to 8090.
  • Modified the Docker smoke test workflow to start two containers:
    1. smoke-test: runs on default port 8080 (mapped to 18080).
    2. smoke-test-custom: runs with the custom config mounted, testing port 8090 (mapped to 18090).
  • Updated the health check waiting logic to poll both containers.
  • Added explicit curl assertions against the /health endpoint for both containers.
  • Enhanced cleanup to output logs for both containers and remove the custom config file.

PR created automatically by Jules for task 1672490460434658714 started by @icebear0828

Updates the `.github/workflows/ci-docker.yml` workflow to start two
containers simultaneously: one using the default configuration (port 8080)
and another using a custom `default.yaml` mounted to the container to
run on port 8090.

This ensures that the Docker image builds correctly and that the container
starts, respects configuration overrides (via the health check script),
and correctly routes traffic on non-default ports.

Co-authored-by: icebear0828 <63769498+icebear0828@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: verify Docker image builds and starts successfully

1 participant