expression: implement vectorized evaluation for builtinCoalesceXXSig (

pingcap#13015)
icditwang · Nov 5, 2019 · 9ada79a · 9ada79a
1 parent 186c6ac
commit 9ada79a
Show file tree

Hide file tree

Showing 4 changed files with 409 additions and 56 deletions.
diff --git a/expression/builtin_compare_vec.go b/expression/builtin_compare_vec.go
@@ -330,14 +330,6 @@ func (b *builtinGTIntSig) vecEvalInt(input *chunk.Chunk, result *chunk.Column) e
 	return nil
 }
 
-func (b *builtinCoalesceDurationSig) vectorized() bool {
-	return false
-}
-
-func (b *builtinCoalesceDurationSig) vecEvalDuration(input *chunk.Chunk, result *chunk.Column) error {
-	return errors.Errorf("not implemented")
-}
-
 func (b *builtinNullEQIntSig) vectorized() bool {
 	return false
 }
@@ -346,22 +338,6 @@ func (b *builtinNullEQIntSig) vecEvalInt(input *chunk.Chunk, result *chunk.Colum
 	return errors.Errorf("not implemented")
 }
 
-func (b *builtinCoalesceRealSig) vectorized() bool {
-	return false
-}
-
-func (b *builtinCoalesceRealSig) vecEvalReal(input *chunk.Chunk, result *chunk.Column) error {
-	return errors.Errorf("not implemented")
-}
-
-func (b *builtinCoalesceStringSig) vectorized() bool {
-	return false
-}
-
-func (b *builtinCoalesceStringSig) vecEvalString(input *chunk.Chunk, result *chunk.Column) error {
-	return errors.Errorf("not implemented")
-}
-
 func (b *builtinIntervalIntSig) vectorized() bool {
 	return true
 }
@@ -453,14 +429,6 @@ func (b *builtinLEIntSig) vecEvalInt(input *chunk.Chunk, result *chunk.Column) e
 	return nil
 }
 
-func (b *builtinCoalesceDecimalSig) vectorized() bool {
-	return false
-}
-
-func (b *builtinCoalesceDecimalSig) vecEvalDecimal(input *chunk.Chunk, result *chunk.Column) error {
-	return errors.Errorf("not implemented")
-}
-
 func (b *builtinLTIntSig) vectorized() bool {
 	return true
 }
@@ -551,14 +519,6 @@ func vecCompareInt(isUnsigned0, isUnsigned1 bool, largs, rargs, result *chunk.Co
 	}
 }
 
-func (b *builtinCoalesceIntSig) vectorized() bool {
-	return false
-}
-
-func (b *builtinCoalesceIntSig) vecEvalInt(input *chunk.Chunk, result *chunk.Column) error {
-	return errors.Errorf("not implemented")
-}
-
 func (b *builtinGreatestTimeSig) vectorized() bool {
 	return false
 }
@@ -567,22 +527,6 @@ func (b *builtinGreatestTimeSig) vecEvalString(input *chunk.Chunk, result *chunk
 	return errors.Errorf("not implemented")
 }
 
-func (b *builtinCoalesceTimeSig) vectorized() bool {
-	return false
-}
-
-func (b *builtinCoalesceTimeSig) vecEvalTime(input *chunk.Chunk, result *chunk.Column) error {
-	return errors.Errorf("not implemented")
-}
-
-func (b *builtinCoalesceJSONSig) vectorized() bool {
-	return false
-}
-
-func (b *builtinCoalesceJSONSig) vecEvalJSON(input *chunk.Chunk, result *chunk.Column) error {
-	return errors.Errorf("not implemented")
-}
-
 func (b *builtinGreatestRealSig) vectorized() bool {
 	return true
 }

diff --git a/expression/builtin_compare_vec_generated.go b/expression/builtin_compare_vec_generated.go
diff --git a/expression/builtin_compare_vec_generated_test.go b/expression/builtin_compare_vec_generated_test.go