Skip to content

Conversation

icd2k3
Copy link
Owner

@icd2k3 icd2k3 commented Mar 18, 2020

Fixes a small issue for those using react-router 5.1. Props were not being forwarded to the wrapped component. For example:

// MyWrapper.js
<Breadcrumbs someOtherProp="hello" />

// Breadcrumbs.js
const PureBreadcrumbs = ({ someOtherProp }) => <span>{someOtherProp}</span> // UNDEFINED!
export default withBreadcrumbs()(PureBreadcrumbs)

Smaller fixes include:

  • bumping some dev dependencies
  • fixing some TS errors
  • adding a test for pass through props

@github-actions
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 74972a0 on cleanup into 3c8adc5 on master.

@icd2k3 icd2k3 merged commit a0b9c1f into master Mar 18, 2020
@icd2k3 icd2k3 deleted the cleanup branch March 18, 2020 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants