Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review the internal data structures in class Query #158

Open
wants to merge 27 commits into
base: develop
Choose a base branch
from
Open

Commits on Aug 23, 2024

  1. Configuration menu
    Copy the full SHA
    ca98b69 View commit details
    Browse the repository at this point in the history
  2. Add helper classes OrderItem and ConditionItem to represent the items

    in the ORDER BY and the WHERE clause respectively
    RKrahl committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    c67d44a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    811de80 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4dec2ed View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9e27157 View commit details
    Browse the repository at this point in the history
  6. Typo in comment

    RKrahl committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    4d58e3d View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2024

  1. Configuration menu
    Copy the full SHA
    397c453 View commit details
    Browse the repository at this point in the history
  2. Minor documentation tweaks

    RKrahl committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    c6c0c52 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Update the source code creating queries to use the new format of the

    conditions argument.  Not yet covered: tests, documentation examples.
    RKrahl committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    f5014cb View commit details
    Browse the repository at this point in the history
  2. Emit a deprecation warning when passing a mapping in the conditions

    argument to Query.addConditions()
    RKrahl committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    2fc5f82 View commit details
    Browse the repository at this point in the history
  3. Update the test_06_query.py to use the new format of the conditions

    argument when creating queries.
    
    Not yet done: verify that evaluating the formal string representation
    of Query works as expected, add tests for the legacy use of a mapping
    and verify that the deprecation warning is indeed being raised.
    RKrahl committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    e47ae77 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. - Update all tests to use the new format of the conditions argument

      when creating queries
    - While we are at it: eliminate a few more occurences of the old
      legacy ICAT query syntax in the tests
    RKrahl committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    ada4100 View commit details
    Browse the repository at this point in the history
  2. Add checks to verify that evaluating the formal string representation

    operator of Query may indeed be used to create an equivalent query to
    the tests in test_06_query.py where it makes sense
    RKrahl committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    50a1063 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Add tests for the legacy use of passing a mapping in the conditions

    argument in class Query.  Also verify that a DeprecationWarning is
    raised.
    RKrahl committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    383c975 View commit details
    Browse the repository at this point in the history
  2. Update example scripts to use the new format of the conditions

    argument when creating queries.  Eliminate a few more occurrences of
    the old legacy ICAT query syntax on the way.
    RKrahl committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    cfc9099 View commit details
    Browse the repository at this point in the history
  3. Update the tutotial section "Searching for objects in the ICAT server"

    to use the new format of the conditions argument when creating
    queries.
    RKrahl committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    60024f9 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Configuration menu
    Copy the full SHA
    38decc0 View commit details
    Browse the repository at this point in the history
  2. Update the tutotial section "Upload and download files to and from

    IDS" to use the new format of the conditions argument when creating
    queries.
    RKrahl committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    93e1a12 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f325880 View commit details
    Browse the repository at this point in the history
  4. Add a test using a query where one attributes appears more than once

    in the ORDER BY clause
    RKrahl committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    587718a View commit details
    Browse the repository at this point in the history
  5. Fixup cfc9099: still missed one occurrence of a mapping in the

    conditions argument
    RKrahl committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    5ed6692 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e9a545f View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Configuration menu
    Copy the full SHA
    b358006 View commit details
    Browse the repository at this point in the history
  2. Review the order of methods in class Query to be consistent with the

    order of the keyword arguments and the order of calling the methods
    during initialization.  This should essentially only have an impact on
    the presentation of the module reference page in the documentation.
    RKrahl committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    8e1e872 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'v2_0' into query

    RKrahl committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    5c7e114 View commit details
    Browse the repository at this point in the history
  4. Update changelog

    RKrahl committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    6db1195 View commit details
    Browse the repository at this point in the history
  5. Add a comment in test_09_deprecations.py that testing the legacy use

    of the conditions argument is done in test_06_query.py
    RKrahl committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    4025818 View commit details
    Browse the repository at this point in the history