Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build issue with latest hassio version #236

Merged
merged 1 commit into from
Apr 10, 2022

Conversation

richardsorensson
Copy link
Contributor

@richardsorensson richardsorensson commented Apr 4, 2022

adding zlib-dev dependency to the dockerfile solves recent build issues with latest hassio version.

while this PR is under review, a manual fix is to do a manual install according to the readme file and then manually replace the docker file after copying the files into the addon\hassio-plejd folder.

@SweVictor
Copy link
Collaborator

@SM6WGG - did you in the end manage to install with the above fix? Who else has verified this fix working? @nik-linds - have you installed using the fix and this verified it?

@SM6WGG
Copy link

SM6WGG commented Apr 8, 2022

@SM6WGG - did you in the end manage to install with the above fix? Who else has verified this fix working? @nik-linds - have you installed using the fix and this verified it?

Yes! I missed the fact that there are two files named the same (Dockerfile). Obviously I replaced the wrong one first. 🤯
So for any one else with the same problem follow the above but make sure to replace the Dockerfile in the main folder (plejd) not the one in .devcontainer

Thanks for the shout back and sorry for stealing your time. 🥳

@FedericoKlappenbach
Copy link

FedericoKlappenbach commented Apr 9, 2022

Edit: Nevermind it works 😅. Cheers.

Hi,
I have the same issue and have exposed my RPi4 Home assistant OS files via Samba. I cannot find where /addon/ directory is. I can only find /addons/ which is where I've tried to install manually. This doesn't resolve the issue for me. Please advice :)

@Tomerello
Copy link

I can confirm that replacing glib-dev with zlib-dev fixed the issue

@SweVictor
Copy link
Collaborator

Perfect, thanks for the update. I'll merge this PR soon and try to get a new release out. In the future, please direct any PRs to the develop branch. Thanks!

@SweVictor SweVictor merged commit f39c0a5 into icanos:master Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants