Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more documentation to install steps #201

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

polyzois
Copy link

No description provided.

@SweVictor
Copy link
Collaborator

Very nice! I like the concept!

However, I do think that the Details.md file needs to be in the plejd directory. The root is a "repository for addons", the plejd folder is the root for the actual addon.

You think you could change that and update the reference in the Readme?

Apart from that I think it looks good. I suppose you have good reasons for updating the mqtt part for example 😄

@SweVictor
Copy link
Collaborator

@polyzois - any thoughts about the comments?

@SweVictor
Copy link
Collaborator

Alright, despite lack of comment I'll merge this and fix file naming in develop branch

@SweVictor SweVictor merged commit 6f269de into icanos:develop Jun 9, 2021
@polyzois
Copy link
Author

polyzois commented Jun 9, 2021 via email

@polyzois
Copy link
Author

polyzois commented Jun 9, 2021 via email

@SweVictor SweVictor mentioned this pull request Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants