-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/restructure ble #167
Conversation
…r/hassio-plejd into feature/restructure-ble
- Make deviceRegistry states/lists immutable
So - finally I'm through with my main thoughts on refactoring the code base. One place where state is stored, BLE handling separate, device state management separately. |
- Set max retry count to 10 since BLE loop will set channel to disconnected after 5 retries (or known unrecoverable errors)
…disposed correctly by underlying code)
Release v0.6.0
- when using includeRoomsAsLights setting
- Make deviceRegistry states/lists immutable
- Set max retry count to 10 since BLE loop will set channel to disconnected after 5 retries (or known unrecoverable errors)
…disposed correctly by underlying code)
…ature/restructure-ble
Really great work done here, love the new structure and the separation of BLE comm. |
Thanks! Yeah, I'm thinking this is shaping up nicely too. Has been some strange stuff with dbus exhausting internal resources, but sharing that instance seems to solve that. I'm long-term testing this now, but so far it looks promising. Other testers are most welcome, I'll probably merge this next week to develop if nothing new comes up. |
So - after a few days working this error surfaced. Emitted from
Seems like the underlying error is Anyone knows this error from before? I managed to solve it temporarily, not sure what though (without restarting). The only command i run (in root console) were (in order)
The error came back after a while, and also persisted addon restart. Power off => wait for a slightly longer time (20+ seconds) seemed to fix it the second time. Any ideas? |
Hmm, so... This keeps happening (have not rebooted the computer, but at least HA supervisor). Current guess is that Power cycling alone does not help. I think this is the source code of |
So. I have in my installation had TONS of disconnects due to a (for now somewhat intentionally) bad placed BLE dongle. I have moved it to a better place now and have no disconnects (and therefore no issues). So - I'll merge this now and might break out the BLE discussion to a separate issue. |
Separate device management and BLE channel handling. Clean up event subscriptions and clarify emits.