Skip to content

Apply #953 for v6: Stop using culture-specific string handling #954

Merged
axunonb merged 5 commits into
mainfrom
wip/axunonb/bugfix/string_cultureinfo
Jun 28, 2026
Merged

Apply #953 for v6: Stop using culture-specific string handling #954
axunonb merged 5 commits into
mainfrom
wip/axunonb/bugfix/string_cultureinfo

Conversation

@axunonb

@axunonb axunonb commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Apply #953 for v6

Resolves #792

@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...erialization/DataTypes/RecurrenceRuleSerializer.cs 50.0% 1 Missing and 1 partial ⚠️
Ical.Net/Serialization/CalendarComponentFactory.cs 0.0% 0 Missing and 1 partial ⚠️

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #954   +/-   ##
=====================================
  Coverage   71.4%   71.4%           
=====================================
  Files        118     118           
  Lines       4608    4608           
  Branches    1084    1084           
=====================================
  Hits        3292    3292           
  Misses       954     954           
  Partials     362     362           
Files with missing lines Coverage Δ
Ical.Net/DataTypes/CalendarDataType.cs 48.3% <100.0%> (ø)
...l.Net/Serialization/DataTypes/WeekDaySerializer.cs 61.3% <100.0%> (ø)
Ical.Net/Serialization/EncodingProvider.cs 100.0% <100.0%> (ø)
Ical.Net/Serialization/CalendarComponentFactory.cs 85.0% <0.0%> (ø)
...erialization/DataTypes/RecurrenceRuleSerializer.cs 92.8% <50.0%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@axunonb axunonb requested a review from maknapp June 23, 2026 07:38
@axunonb axunonb merged commit 9a888e1 into main Jun 28, 2026
11 of 12 checks passed
@axunonb axunonb deleted the wip/axunonb/bugfix/string_cultureinfo branch June 28, 2026 17:42
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parsing fails in certain cultures

3 participants