Issue273 testcase multizone office simple air #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in oad pos adjust based on fan speed
javiarrobas
requested changes
Apr 5, 2022
There was a problem hiding this comment.
Thanks a lot, @dhblum and @Mathadon for the continued efforts!
It is looking good to me. I would just suggest to add this emulator to the compare_references.py file with a few critical/representative variables of this model. I believe this is good practice for future revisions to check on potential reference changes.
|
@JavierArroyoBastida Thanks for the review! |
|
I see. Looking great, thanks! I'd suggest merging once tests pass. |
javiarrobas
approved these changes
Apr 7, 2022
|
Sounds good, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #273. In particular, it implements the test case.
@JavierArroyoBastida The detailed test case review process with @Mathadon has completed and I have prepared the test case for merging. Do you mind briefly reviewing this though to make sure everything is in order?