Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for event update at start of simulation step #284

Merged
merged 5 commits into from
Feb 9, 2021

Conversation

dhblum
Copy link
Collaborator

@dhblum dhblum commented Feb 5, 2021

This PR is for #274, though implements a generic fix for event handling at the start of a simulation step. In particular, it:

  • Adds a test for improper event handling using the bestest_hydronic_heat_pump test case as described in TestCase: Bestest Hydronic pump control #274
  • Adds a line to Dockerfile that writes code in pyfmi to fix event handling at start of simulation step
  • Adds correct test reference results, verified by comparison to results generated by Dymola with Dassl solver tol 1e-6 and use of Modelica.Blocks.Sources.Pulse for pump signal injection
  • Updates reference results for testcase2, which had very small numeric differences

Copy link
Contributor

@javiarrobas javiarrobas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me. Thanks @dhblum for getting this implemented.

@dhblum dhblum merged commit fdc1cde into master Feb 9, 2021
@dhblum dhblum deleted the issue274_hydronicPumpControl branch February 9, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants