-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python3 support, except parser #229
Conversation
@JavierArroyoBastida When you get a chance can you review this? |
Hi Guys, I got two issues when using this updated Docker:
|
Thanks Sen for taking a look. All of the tests passed 6 days ago, which include running all of the models in the test case container. I'll need to look into these issues. Can you clarify:
|
Sorry for the confusion.
|
@SenHuang19 Can you please be more specific? On both Ubuntu 16.04 and 18.04 I ran What test cases are you having issues with? What commands are you running that invoke the errors? What are some system specs (e.g. OS and version) that you are running on? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Most of the tests pass in my local host using a Python3 environment. The tests that don’t pass (test_data_manager
, test_forecast
, and test_kpis
) are due to inability to load Linux compiled model binaries in my Windows platform. However, having them passing in Travis and all the other tests passing locally prove the sanity of those modules.
Apart from that, the tests properly invoke the boptest image (using Python3) or the jmodelica image (using Python2) depending on what’s needed. This way, the use of Python2 is indeed fairly confined only to the use of the parser
and the data_generator
.
I've included a few comments requesting minor changes. Also I see now that parsing/SimpleRC_noSignalExchangeBlocks.mo
is using lowercase whereas the test is using capital letter in here:
project1-boptest/testing/test_parser.py
Line 344 in 321c298
self.mo_path = os.path.join(testing_root_dir,'parsing', 'SimpleRC_NoSignalExchangeBlocks.mo') |
This needs correction as well.
We shouldn't merge this until the issue described here is resolved: #146 (comment) |
Closing until can resolve the above mentioned issues. |
For #146 and #228
parser/parser.py
anddata/data_generator.py
. These still require Python2 due to JModelica.org dependence for compiling FMUs. Therefore, their unittests (testing/makefile test_parser
andtesting/makefile test_data_generator
) also still must be run injm
testing docker image, which contains JModelica.org and Python2.