Issue162 testcase single zone commercial #160

taoyyt · 2020-03-18T14:02:49Z

This is the emulator of Single Zone Commercial building from SDU, Denmark

add review document

add occupancy doc

dhblum · 2020-04-16T23:28:20Z

Thanks a lot @TaoYang-CFEI for making this PR. This model is almost there I think. I have a number of comments that should be addressed though:

The directory structure should follow for example testcases/testcase1 and testcases/testcase2. That is, within testcases/singleZoneCommercial, there should be a models directory, doc directory, and config.py file. Within /models is where you should place the files required for your model, and there should be a Resources directory for the data .csv files.
Please generate the data .csv files and place them in the Resources directory.
Please finalize the documentation of the model, as some sections are blank.
OU44Emulator.Models.Validation.RealOccupancy.read_Tzone.KPIs should be tagged as Air zone Temperature.
OU44Emulator.Models.Validation.RealOccupancy.read_Q_el and OU44Emulator.Models.Validation.RealOccupancy.read_Q_h specify power measurements, however, they are actually energy measurements since they are after the integrators. These measurements should be before the integrators. Please also specify the unit as W.
All Read and Overwrite blocks should specify units. Use standard units, such as K, W, and ppm.
The definition of the construction floor should use Buildings.HeatTransfer.Data.OpaqueConstructions.Generic and also specify that the parameter nLay=2. Similar for roof and intWall (except for this one nLay=1).
You can probably speed up simulation time a lot if in your occ.txt file you only specify the times that the value changes, perhaps even by a particular threshold, rather than specifying a value every 60s.

…ercial Remotes/origin/single zone commercial

taoyyt · 2020-07-27T17:18:14Z

Many thanks for your comments @dhblum, the updated version has been uploaded, please take a look, further comments are more than welcome.

dhblum · 2020-08-21T15:50:59Z

Thanks @TaoYang-CFEI. I am planning to review in the next week.

dhblum · 2020-08-25T13:56:15Z

@TaoYang-CFEI Thanks a lot for the revisions! This looks very good, and addressed all of my comments I listed before.

I am going to do some additional testing with the BOPTEST framework, add associated unit tests, and maybe fix some small typos I see in the documentation. In this case, are you ok with me pushing some changes to your fork branch?

In the meantime, can you please add more details to the documentation of inputs and outputs? Please add the variable name (e.g. "read_Tzone" - the name of the signal exchange block instance), unit, min, and max. Also make sure the description matches what is in the signal exchange block instance.

After this, it would be good too to have another review check with the most recent review checklist, v1.3 (most updates are related to the BOPTEST stuff, and not as much the modeling, which has been reviewed by the checklist uploaded with the model already). Is Valentin still available for this?

taoyyt · 2020-08-25T14:17:01Z

@dhblum thanks for the feedback, please feel free to push any changes to my fork branch. I will further update the model with the comments. Besides, I am planning to update the newest review checklist myself if that is OK, since Valentin may not be available for it. Also, I think will provide the updated review checklist for Valentin's model within the next two weeks.

dhblum · 2020-08-26T13:21:18Z

@TaoYang-CFEI Ok I will push some changes and also look for your updates to the documentation (see here for an example).

I think it would be better if someone other than you completed the review checklist, as the review process should serve as a peer review. I can do that, having gone through the model twice already. If you can focus on reviewing Valentin's model within the next two weeks, that would be great.

taoyyt · 2020-08-26T13:30:23Z

@dhblum Thanks a lot, that works great!

…to singleZoneCommercial

…I/project1-boptest into singleZoneCommercial

dhblum · 2020-08-27T15:39:21Z

@TaoYang-CFEI I was able to simulate the model for 1 year using cvode in Dymola. However, when I try to simulate the model with JModelica (pyfmi) cvode solver, I get errors in the solver. For instance, trying to simulate the model for 10 days gives me:

Traceback (most recent call last):
  File "simulate_fmu.py", line 5, in <module>
    model.simulate(0,3600*24*10, options=options)
  File "src/pyfmi/fmi.pyx", line 7522, in pyfmi.fmi.FMUModelME2.simulate
  File "src/pyfmi/fmi.pyx", line 304, in pyfmi.fmi.ModelBase._exec_simulate_algorithm
  File "src/pyfmi/fmi.pyx", line 300, in pyfmi.fmi.ModelBase._exec_simulate_algorithm
  File "/home/dhbubu18/JModelica/trunk/JModelica/Python/pyfmi/fmi_algorithm_drivers.py", line 520, in solve
    self.simulator.simulate(self.final_time, self.ncp)
  File "assimulo/ode.pyx", line 168, in assimulo.ode.ODE.simulate
  File "assimulo/ode.pyx", line 288, in assimulo.ode.ODE.simulate
  File "assimulo/explicit_ode.pyx", line 101, in assimulo.explicit_ode.Explicit_ODE._simulate
  File "assimulo/explicit_ode.pyx", line 187, in assimulo.explicit_ode.Explicit_ODE._simulate
  File "assimulo/solvers/sundials.pyx", line 1894, in assimulo.solvers.sundials.CVode.integrate
  File "assimulo/solvers/sundials.pyx", line 1926, in assimulo.solvers.sundials.CVode.integrate
  assimulo.solvers.sundials.CVodeError: 'The right-hand side function had repeated recoverable errors. At time 0.095120.'

Have you ever tested simulating the model with JModelica?

taoyyt · 2020-08-28T08:36:11Z

@dhblum I have not tested the model with JModelica. I actually have no clue how the error comes either.

dhblum · 2020-08-28T13:13:01Z

Ok thanks @TaoYang-CFEI. I'll be taking a look at it.

dhblum · 2020-10-05T14:02:15Z

Just an update here. If I remove the PID controllers for the radiator and AHU valve and replace with constant 0s, it simulates ok. So it seems to be something around the controls that are causing the issue.

taoyyt · 2020-10-13T18:53:38Z

@dhblum Just want to make sure I understand correctly the error, then I can start to debug it. Did you export the model fmu, and run it with python PyFMI interface instead of running the model itself in Jmodelica?

dhblum · 2020-10-13T19:14:47Z

@TaoYang-CFEI Thanks for clarifying. No, I tried to run the model with JModelica. I first compile the FMU with JModelica, then simulate the FMU with JModelica.

filokot · 2020-10-14T16:13:47Z

Thanks, @dhblum for helping us reproduce the issue:

CVodeError                                Traceback (most recent call last)
<ipython-input-9-0945e76ff542> in <module>()
----> 1 sim=fmu_in.simulate(final_time=86400)
src\pyfmi\fmi.pyx in pyfmi.fmi.FMUModelME2.simulate (src\pyfmi\fmi.c:83783)()
src\pyfmi\fmi.pyx in pyfmi.fmi.ModelBase._exec_simulate_algorithm (src\pyfmi\fmi.c:6410)()
src\pyfmi\fmi.pyx in pyfmi.fmi.ModelBase._exec_simulate_algorithm (src\pyfmi\fmi.c:6327)()
C:\JModelica.org-2.4\install\Python_64\pyfmi\fmi_algorithm_drivers.pyc in solve(self)
    519         time_start = timer()
    520
--> 521         self.simulator.simulate(self.final_time, self.ncp)
    522
    523         self.timings["storing_result"] = self.probl.timings["handle_result"]
assimulo\ode.pyx in assimulo.ode.ODE.simulate (assimulo\ode.c:6667)()
assimulo\ode.pyx in assimulo.ode.ODE.simulate (assimulo\ode.c:6066)()
assimulo\explicit_ode.pyx in assimulo.explicit_ode.Explicit_ODE._simulate (assimulo\explicit_ode.c:4985)()
assimulo\explicit_ode.pyx in assimulo.explicit_ode.Explicit_ODE._simulate (assimulo\explicit_ode.c:3702)()
assimulo\solvers\sundials.pyx in assimulo.solvers.sundials.CVode.integrate (assimulo\solvers\sundials.c:38115)()
assimulo\solvers\sundials.pyx in assimulo.solvers.sundials.CVode.integrate (assimulo\solvers\sundials.c:36948)()
CVodeError: 'The right-hand side function had repeated recoverable errors. At time 2923.212443.'

What I have noticed is that I get a number of warnings while compiling the fmu. Did you see similar output when compiling the FMU?

Warning at line 1775, column 5, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Blocks\Continuous.mo',
In component airHandlingUnit.fanEx:
  The parameter airHandlingUnit.fanEx.filter.c0 does not have a binding expression
Warning at line 1775, column 5, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Blocks\Continuous.mo',
In component airHandlingUnit.fanSu:
  The parameter airHandlingUnit.fanSu.filter.c0 does not have a binding expression
Warning at line 1775, column 5, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Blocks\Continuous.mo',
In component districtHeating.pmp1:
  The parameter districtHeating.pmp1.filter.c0 does not have a binding expression
Warning at line 1775, column 5, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Blocks\Continuous.mo',
In component districtHeating.pmp2:
  The parameter districtHeating.pmp2.filter.c0 does not have a binding expression
Warning at line 1776, column 5, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Blocks\Continuous.mo',
In component airHandlingUnit.fanEx:
  The parameter airHandlingUnit.fanEx.filter.c1 does not have a binding expression
Warning at line 1776, column 5, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Blocks\Continuous.mo',
In component airHandlingUnit.fanSu:
  The parameter airHandlingUnit.fanSu.filter.c1 does not have a binding expression
Warning at line 1776, column 5, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Blocks\Continuous.mo',
In component districtHeating.pmp1:
  The parameter districtHeating.pmp1.filter.c1 does not have a binding expression
Warning at line 1776, column 5, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Blocks\Continuous.mo',
In component districtHeating.pmp2:
  The parameter districtHeating.pmp2.filter.c1 does not have a binding expression
Warning at line 1780, column 5, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Blocks\Continuous.mo',
In component airHandlingUnit.fanEx:
  The parameter airHandlingUnit.fanEx.filter.a does not have a binding expression
Warning at line 1780, column 5, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Blocks\Continuous.mo',
In component airHandlingUnit.fanSu:
  The parameter airHandlingUnit.fanSu.filter.a does not have a binding expression
Warning at line 1780, column 5, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Blocks\Continuous.mo',
In component districtHeating.pmp1:
  The parameter districtHeating.pmp1.filter.a does not have a binding expression
Warning at line 1780, column 5, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Blocks\Continuous.mo',
In component districtHeating.pmp2:
  The parameter districtHeating.pmp2.filter.a does not have a binding expression
Warning at line 1781, column 5, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Blocks\Continuous.mo',
In component airHandlingUnit.fanEx:
  The parameter airHandlingUnit.fanEx.filter.b does not have a binding expression
Warning at line 1781, column 5, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Blocks\Continuous.mo',
In component airHandlingUnit.fanSu:
  The parameter airHandlingUnit.fanSu.filter.b does not have a binding expression
Warning at line 1781, column 5, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Blocks\Continuous.mo',
In component districtHeating.pmp1:
  The parameter districtHeating.pmp1.filter.b does not have a binding expression
Warning at line 1781, column 5, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Blocks\Continuous.mo',
In component districtHeating.pmp2:
  The parameter districtHeating.pmp2.filter.b does not have a binding expression
Warning at line 1782, column 5, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Blocks\Continuous.mo',
In component airHandlingUnit.fanEx:
  The parameter airHandlingUnit.fanEx.filter.ku does not have a binding expression
Warning at line 1782, column 5, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Blocks\Continuous.mo',
In component airHandlingUnit.fanSu:
  The parameter airHandlingUnit.fanSu.filter.ku does not have a binding expression
Warning at line 1782, column 5, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Blocks\Continuous.mo',
In component districtHeating.pmp1:
  The parameter districtHeating.pmp1.filter.ku does not have a binding expression
Warning at line 1782, column 5, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Blocks\Continuous.mo',
In component districtHeating.pmp2:
  The parameter districtHeating.pmp2.filter.ku does not have a binding expression
Warning at line 1783, column 5, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Blocks\Continuous.mo',
In component airHandlingUnit.fanEx:
  The parameter airHandlingUnit.fanEx.filter.k1 does not have a binding expression
Warning at line 1783, column 5, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Blocks\Continuous.mo',
In component airHandlingUnit.fanSu:
  The parameter airHandlingUnit.fanSu.filter.k1 does not have a binding expression
Warning at line 1783, column 5, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Blocks\Continuous.mo',
In component districtHeating.pmp1:
  The parameter districtHeating.pmp1.filter.k1 does not have a binding expression
Warning at line 1783, column 5, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Blocks\Continuous.mo',
In component districtHeating.pmp2:
  The parameter districtHeating.pmp2.filter.k1 does not have a binding expression
Warning at line 1785, column 5, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Blocks\Continuous.mo',
In component airHandlingUnit.fanEx:
  The parameter airHandlingUnit.fanEx.filter.k2 does not have a binding expression
Warning at line 1785, column 5, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Blocks\Continuous.mo',
In component airHandlingUnit.fanSu:
  The parameter airHandlingUnit.fanSu.filter.k2 does not have a binding expression
Warning at line 1785, column 5, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Blocks\Continuous.mo',
In component districtHeating.pmp1:
  The parameter districtHeating.pmp1.filter.k2 does not have a binding expression
Warning at line 1785, column 5, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Blocks\Continuous.mo',
In component districtHeating.pmp2:
  The parameter districtHeating.pmp2.filter.k2 does not have a binding expression
Warning at line 782, column 14, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Fluid\Sources.mo',
In components:
    airHandlingUnit.outEx
    airHandlingUnit.outSu
    infiltration.freshAir
    infiltration.infiltr
  The cardinality() function-like operator is deprecated, and will be removed in a future version of Modelica
Warning at line 104, column 23, in file 'C:\Users\kfi\Desktop\jmodelica_boptest\Buildings 5.0.1\Controls\SetPoints\OccupancySchedule.mo',
In components:
    Occupancy_schedule
    Occupancy_schedule1
  Variable array index in equation can result in slow simulation time
Warning at line 105, column 23, in file 'C:\Users\kfi\Desktop\jmodelica_boptest\Buildings 5.0.1\Controls\SetPoints\OccupancySchedule.mo',
In components:
    Occupancy_schedule
    Occupancy_schedule1
  Variable array index in equation can result in slow simulation time
Warning at line 123, column 22, in file 'C:\Users\kfi\Desktop\jmodelica_boptest\Buildings 5.0.1\Controls\SetPoints\OccupancySchedule.mo',
In components:
    Occupancy_schedule
    Occupancy_schedule1
  Variable array index in equation can result in slow simulation time
Warning at line 135, column 26, in file 'C:\Users\kfi\Desktop\jmodelica_boptest\Buildings 5.0.1\Controls\SetPoints\OccupancySchedule.mo',
In components:
    Occupancy_schedule
    Occupancy_schedule1
  Variable array index in equation can result in slow simulation time
Warning at line 48, column 3, in file 'C:\Users\kfi\Desktop\jmodelica_boptest\Buildings 5.0.1\Fluid\Actuators\BaseClasses\PartialThreeWayValve.mo',
In components:
    valCoil
    valRad
  The component deltaM is declared multiple times and can not be verified to be identical to other declaration(s) with the same name.
Warning at line 26, column 3, in file 'C:\Users\kfi\Desktop\jmodelica_boptest\Buildings 5.0.1\Fluid\Actuators\BaseClasses\ValveParameters.mo',
In components:
    valCoil.res1
    valCoil.res3
    valRad.res1
    valRad.res3
  The component m_flow_nominal is declared multiple times and can not be verified to be identical to other declaration(s) with the same name.
Warning at line 9, column 3, in file 'C:\Users\kfi\Desktop\jmodelica_boptest\Buildings 5.0.1\Fluid\HeatExchangers\BaseClasses\PartialPrescribedOutlet.mo',
In component districtHeating.hea:
  The component m_flow_nominal is declared multiple times and can not be verified to be identical to other declaration(s) with the same name.
Warning at line 20, column 3, in file 'C:\Users\kfi\Desktop\jmodelica_boptest\Buildings 5.0.1\Fluid\Interfaces\PrescribedOutlet.mo',
In component districtHeating.hea:
  The component m_flow_nominal is declared multiple times and can not be verified to be identical to other declaration(s) with the same name.
Warning at line 36, column 51, in file 'C:\Users\kfi\Desktop\jmodelica_boptest\Buildings 5.0.1\ThermalZones\Detailed\BaseClasses\ExteriorBoundaryConditionsWithWindow.mo',
In component ou44Bdg.bouConExtWin:
  Assuming 'each' for the modification 'min = 0'
Warning at line 36, column 58, in file 'C:\Users\kfi\Desktop\jmodelica_boptest\Buildings 5.0.1\ThermalZones\Detailed\BaseClasses\ExteriorBoundaryConditionsWithWindow.mo',
In component ou44Bdg.bouConExtWin:
  Assuming 'each' for the modification 'max = 1'
Warning at line 24, column 3, in file 'C:\Users\kfi\Desktop\jmodelica_boptest\Buildings 5.0.1\ThermalZones\Detailed\BaseClasses\PartialAirHeatMassBalance.mo',
In component ou44Bdg.air:
  Assuming 'each' for the modification 'final unit = "W"'
Warning at line 38, column 4, in file 'C:\Users\kfi\Desktop\jmodelica_boptest\Buildings 5.0.1\ThermalZones\Detailed\BaseClasses\PartialAirHeatMassBalance.mo',
In component ou44Bdg.air:
  Assuming 'each' for the modification 'final unit = "K"'
Warning at line 39, column 4, in file 'C:\Users\kfi\Desktop\jmodelica_boptest\Buildings 5.0.1\ThermalZones\Detailed\BaseClasses\PartialAirHeatMassBalance.mo',
In component ou44Bdg.air:
  Assuming 'each' for the modification 'final quantity = "ThermodynamicTemperature"'
sources/ModelicaInternal_readLine.c: In function 'main':
sources/ModelicaInternal_readLine.c:180:22: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
             string_v = ModelicaInternal_readLine(fileName_v, tmp_1, &tmp_2);
                      ^
sources/ModelicaStrings_substring.c: In function 'main':
sources/ModelicaStrings_substring.c:180:22: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
             result_v = ModelicaStrings_substring(string_v, tmp_1, tmp_2);
                      ^
Warning at line 1757, column 5, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Blocks\Continuous.mo':
  Iteration variable "airHandlingUnit.fanEx.filter.x[1]" is missing start value!
Warning at line 1757, column 5, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Blocks\Continuous.mo':
  Iteration variable "airHandlingUnit.fanSu.filter.x[1]" is missing start value!
Warning at line 1757, column 5, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Blocks\Continuous.mo':
  Iteration variable "districtHeating.pmp1.filter.x[1]" is missing start value!
Warning at line 1757, column 5, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Blocks\Continuous.mo':
  Iteration variable "districtHeating.pmp2.filter.x[1]" is missing start value!
Warning at line 569, column 7, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Thermal\HeatTransfer.mo':
  Iteration variable "ou44Bdg.bouConExtWin.conExtWin[1].conWinUns.dT" is missing start value!
Warning at line 569, column 7, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Thermal\HeatTransfer.mo':
  Iteration variable "ou44Bdg.bouConExtWin.conExtWin[2].conWinUns.dT" is missing start value!
Warning at line 569, column 7, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Thermal\HeatTransfer.mo':
  Iteration variable "ou44Bdg.bouConExtWin.conExtWin[3].conWinUns.dT" is missing start value!
Warning at line 569, column 7, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Thermal\HeatTransfer.mo':
  Iteration variable "ou44Bdg.bouConExtWin.conExtWin[4].conWinUns.dT" is missing start value!
Warning at line 2866, column 7, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Thermal\HeatTransfer.mo':
  Iteration variable "ou44Bdg.conExtWin[1].win.glaSha.gas[1].dT" is missing start value!
Warning at line 2866, column 7, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Thermal\HeatTransfer.mo':
  Iteration variable "ou44Bdg.conExtWin[1].win.glaUns.gas[1].dT" is missing start value!
Warning at line 2866, column 7, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Thermal\HeatTransfer.mo':
  Iteration variable "ou44Bdg.conExtWin[2].win.frame.dT" is missing start value!
Warning at line 2866, column 7, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Thermal\HeatTransfer.mo':
  Iteration variable "ou44Bdg.conExtWin[2].win.glaSha.gas[1].dT" is missing start value!
Warning at line 2866, column 7, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Thermal\HeatTransfer.mo':
  Iteration variable "ou44Bdg.conExtWin[2].win.glaUns.gas[1].dT" is missing start value!
Warning at line 2866, column 7, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Thermal\HeatTransfer.mo':
  Iteration variable "ou44Bdg.conExtWin[3].win.frame.dT" is missing start value!
Warning at line 2866, column 7, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Thermal\HeatTransfer.mo':
  Iteration variable "ou44Bdg.conExtWin[3].win.glaSha.gas[1].dT" is missing start value!
Warning at line 2866, column 7, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Thermal\HeatTransfer.mo':
  Iteration variable "ou44Bdg.conExtWin[3].win.glaUns.gas[1].dT" is missing start value!
Warning at line 2866, column 7, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Thermal\HeatTransfer.mo':
  Iteration variable "ou44Bdg.conExtWin[4].win.frame.dT" is missing start value!
Warning at line 2866, column 7, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Thermal\HeatTransfer.mo':
  Iteration variable "ou44Bdg.conExtWin[4].win.glaSha.gas[1].dT" is missing start value!
Warning at line 2866, column 7, in file 'C:\JModelica.org-2.4\install\ThirdParty\MSL\Modelica\Thermal\HeatTransfer.mo':
  Iteration variable "ou44Bdg.conExtWin[4].win.glaUns.gas[1].dT" is missing start value!
Warning at line 6, column 3, in file 'C:\Users\kfi\Desktop\jmodelica_boptest\Buildings 5.0.1\HeatTransfer\Radiosity\RadiositySplitter.mo':
  Iteration variable "ou44Bdg.radShaOut[1].JIn" is missing start value!
Warning at line 132, column 7, in file 'C:\Users\kfi\Desktop\jmodelica_boptest\project1-boptest\testcases\singleZoneCommercial\models\OU44Emulator\Models\BuildingBase.mo',
In component districtHeating:
  Ignored connection from connector to itself
Warning at line 491, column 7, in file 'C:\Users\kfi\Desktop\jmodelica_boptest\project1-boptest\testcases\singleZoneCommercial\models\OU44Emulator\Models\BuildingBase.mo',
In component airHandlingUnit:
  Ignored connection from connector to itself
sources/OU44Emulator_Models_Validation_RealOccupancy_equ_init.c: In function 'model_ode_initialize_4':
sources/OU44Emulator_Models_Validation_RealOccupancy_equ_init.c:7892:9: warning: string length '613' is greater than the length '509' ISO C90 compilers are required to support [-Woverlength-strings]
         jmi_assert_failed("*** Warning: You are using a flow or pressure controlled mover with the\n             default pressure curve and you set use_powerCharacteristic = true.\n             Since this can cause wrong power consumption, the model will overwrite\n             this setting and use instead use_powerCharacteristic = false.\n             Since this causes the efficiency curve to be used,\n             make sure that the efficiency curves in the performance record per\n             are correct or add the pressure curve of the mover.\n             Setting nominalValuesDefineDefaultPressureCurve=true will suppress this warning.", JMI_ASSERT_WARNING);
         ^
sources/OU44Emulator_Models_Validation_RealOccupancy_equ_init.c:7987:9: warning: string length '613' is greater than the length '509' ISO C90 compilers are required to support [-Woverlength-strings]
         jmi_assert_failed("*** Warning: You are using a flow or pressure controlled mover with the\n             default pressure curve and you set use_powerCharacteristic = true.\n             Since this can cause wrong power consumption, the model will overwrite\n             this setting and use instead use_powerCharacteristic = false.\n             Since this causes the efficiency curve to be used,\n             make sure that the efficiency curves in the performance record per\n             are correct or add the pressure curve of the mover.\n             Setting nominalValuesDefineDefaultPressureCurve=true will suppress this warning.", JMI_ASSERT_WARNING);
         ^
sources/OU44Emulator_Models_Validation_RealOccupancy_equ_init.c:9209:9: warning: string length '613' is greater than the length '509' ISO C90 compilers are required to support [-Woverlength-strings]
         jmi_assert_failed("*** Warning: You are using a flow or pressure controlled mover with the\n             default pressure curve and you set use_powerCharacteristic = true.\n             Since this can cause wrong power consumption, the model will overwrite\n             this setting and use instead use_powerCharacteristic = false.\n             Since this causes the efficiency curve to be used,\n             make sure that the efficiency curves in the performance record per\n             are correct or add the pressure curve of the mover.\n             Setting nominalValuesDefineDefaultPressureCurve=true will suppress this warning.", JMI_ASSERT_WARNING);
         ^
sources/OU44Emulator_Models_Validation_RealOccupancy_equ_init.c:9301:9: warning: string length '613' is greater than the length '509' ISO C90 compilers are required to support [-Woverlength-strings]
         jmi_assert_failed("*** Warning: You are using a flow or pressure controlled mover with the\n             default pressure curve and you set use_powerCharacteristic = true.\n             Since this can cause wrong power consumption, the model will overwrite\n             this setting and use instead use_powerCharacteristic = false.\n             Since this causes the efficiency curve to be used,\n             make sure that the efficiency curves in the performance record per\n             are correct or add the pressure curve of the mover.\n             Setting nominalValuesDefineDefaultPressureCurve=true will suppress this warning.", JMI_ASSERT_WARNING);
         ^

dhblum · 2020-10-20T14:35:47Z

@filokot Yes I get those warnings as well. Also, while I'm glad you reproduced the error, just wanted to point out that it is not exact. The integration time your error reports is 2923.212443 while mine is 0.095120. I'm compiling using Buildings Library v7.0.0 and latest JModelica trunk (which is what BOPTEST uses in unit tests).

…to singleZoneCommercial

dhblum · 2021-10-22T21:48:05Z

@taoyyt Subject to passing the unit tests, I think this is very close to merging. I wanted to make you aware of my recent changes and see if you had any problems, comments, or feedback on them, or anything else before this is merged.

…to singleZoneCommercial

dhblum · 2021-12-08T16:50:13Z

This is ready to merge if tests pass.

taoyyt and others added 4 commits March 18, 2020 14:36

add emulator of single zone commercial building

d54ebc5

Update README.md

7da5407

Add files via upload

a7cddee

add review document

Add files via upload

0d74a83

add occupancy doc

dhblum mentioned this pull request Mar 19, 2020

TestCase: Single Zone Commercial Hydronic #162

Closed

dhblum changed the title ~~Single zone commercial~~ Issue 162 testcase single zone commercial Mar 20, 2020

dhblum changed the title ~~Issue 162 testcase single zone commercial~~ Issue162 testcase single zone commercial Mar 20, 2020

taoyyt and others added 2 commits July 27, 2020 17:52

update based on Dave's comments

02fa374

Merge pull request #1 from TaoYang-CFEI/remotes/origin/singleZoneComm…

6921e1d

…ercial Remotes/origin/single zone commercial

dhblum and others added 3 commits August 26, 2020 06:32

Merge branch 'master' of https://github.com/ibpsa/project1-boptest in…

53cbb5e

…to singleZoneCommercial

update documentation

cd08cc4

Merge branch 'singleZoneCommercial' of https://github.com/TaoYang-CFE…

286d9d3

…I/project1-boptest into singleZoneCommercial

taoyyt and others added 2 commits October 14, 2020 20:15

update model

e80cc9a

occ.txt added - Tao, please check that added to the right folder

713fa9c

update model controller

9af55de

dhblum added 16 commits October 21, 2021 12:39

Fix unit test results

4af4297

Documentation updates

33e5b60

Fix occ.txt so not to have negative occupancy at end of year

13bf512

Update Resources data

480445a

Add script to get I/O

fafae0d

Update overwrite_no_data points

f373877

Update unit test references results

33ca263

Add hydronic heating system schematic and export to doc html

04c1ea2

Change name to singlezone_commercial_hydronic

c7c7f81

Add test case description

1ff8aed

Update contributors

4a58099

Merge branch 'master' of https://github.com/ibpsa/project1-boptest in…

42dbe51

…to singleZoneCommercial

Update release notes

0fd225c

Update releasenotes.md

180c7d1

Update test case name in testing makefile

d8c31fe

Add additional measurement points per BMS graphic

5349588

dhblum added 11 commits November 4, 2021 13:17

Remove .vscode folder

4440ccb

Update wrapped fmu

0b29f40

Merge branch 'master' of https://github.com/ibpsa/project1-boptest in…

c6a7ace

…to singleZoneCommercial

Update test case description in readme

d1a3988

Add revisions section to documentation

9d587e5

Fix typo and spell out SDU in documentation

aa4c477

Refine explanation for CO2 gen factor of 4

84709bb

Add building occ count as measurement

04ad2e7

Add overwrite signals for coil and radiator control valves

1c5fbc7

Update unit test reference results

b533c60

Update wrapped fmu

13c90bb

dhblum merged commit dd7ae8d into ibpsa:master Dec 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue162 testcase single zone commercial #160

Issue162 testcase single zone commercial #160

taoyyt commented Mar 18, 2020

dhblum commented Apr 16, 2020 •

edited

Loading

taoyyt commented Jul 27, 2020

dhblum commented Aug 21, 2020

dhblum commented Aug 25, 2020

taoyyt commented Aug 25, 2020

dhblum commented Aug 26, 2020 •

edited

Loading

taoyyt commented Aug 26, 2020

dhblum commented Aug 27, 2020 •

edited

Loading

taoyyt commented Aug 28, 2020

dhblum commented Aug 28, 2020

dhblum commented Oct 5, 2020

taoyyt commented Oct 13, 2020

dhblum commented Oct 13, 2020

filokot commented Oct 14, 2020

dhblum commented Oct 20, 2020

dhblum commented Oct 22, 2021

dhblum commented Dec 8, 2021

Issue162 testcase single zone commercial #160

Issue162 testcase single zone commercial #160

Conversation

taoyyt commented Mar 18, 2020

dhblum commented Apr 16, 2020 • edited Loading

taoyyt commented Jul 27, 2020

dhblum commented Aug 21, 2020

dhblum commented Aug 25, 2020

taoyyt commented Aug 25, 2020

dhblum commented Aug 26, 2020 • edited Loading

taoyyt commented Aug 26, 2020

dhblum commented Aug 27, 2020 • edited Loading

taoyyt commented Aug 28, 2020

dhblum commented Aug 28, 2020

dhblum commented Oct 5, 2020

taoyyt commented Oct 13, 2020

dhblum commented Oct 13, 2020

filokot commented Oct 14, 2020

dhblum commented Oct 20, 2020

dhblum commented Oct 22, 2021

dhblum commented Dec 8, 2021

dhblum commented Apr 16, 2020 •

edited

Loading

dhblum commented Aug 26, 2020 •

edited

Loading

dhblum commented Aug 27, 2020 •

edited

Loading