Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit tests to report output #466

Closed
dhblum opened this issue Aug 5, 2022 · 1 comment · Fixed by #467
Closed

Fix unit tests to report output #466

dhblum opened this issue Aug 5, 2022 · 1 comment · Fixed by #467
Assignees
Labels
bug Something isn't working

Comments

@dhblum
Copy link
Collaborator

dhblum commented Aug 5, 2022

Before, #450, testing/report.py was used to generate a failure exit code if the make test_all unit test target failed. See the call to report.py in the testing makefile (https://github.com/ibpsa/project1-boptest/blob/master/testing/makefile#L254) and the exit code spec set in report.py (https://github.com/ibpsa/project1-boptest/blob/master/testing/report.py#L84). With #450 implemented, this reporting now needs to be implemented in each job, otherwise, individual tests can fail but travis doesn't know about it, as has happened in this case: https://app.travis-ci.com/github/ibpsa/project1-boptest/jobs/578820097. This issue will fix this.

@kbenne this will need to be addressed in Service too.

@dhblum dhblum added the bug Something isn't working label Aug 5, 2022
@dhblum
Copy link
Collaborator Author

dhblum commented Aug 8, 2022

Closed by #467.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants