Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refrigerants #1180

Closed
wants to merge 3 commits into from
Closed

Conversation

cvering
Copy link
Contributor

@cvering cvering commented Jul 16, 2019

This closes #1093

Hey alltogether, we merged our media models in the IBPSA structure. Therefore, we deleted Massimo Cimminos media model of R410A to avoid naming conflicts. Proving our approach, we added Validation Tests. At the same time we will go for a journal publication to show the functionalities in detail.

@mwetter
Copy link
Contributor

mwetter commented Jul 18, 2019

@cvering : Can you please make a pull request against the branch issue1093_RefrigerantMerge which I just created so we can revise before putting it on the master.
Before you make the pull request, please merge the latest master to your branch.
Also, please make sure your pull request only has files that indeed changes (currently there are hundreds of files that have only changes in formatting that should be removed).

@mwetter
Copy link
Contributor

mwetter commented Nov 15, 2022

Pull request will be closed and @cvering will open a new PR when he merged the updated master (which is now using MSL 4) to the refrigerant development branch.

@mwetter mwetter closed this Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New refrigerant package
2 participants