Skip to content

Commit

Permalink
Adapt comments #1575
Browse files Browse the repository at this point in the history
  • Loading branch information
LauraMaier committed Oct 6, 2023
1 parent ae10ce0 commit c17683c
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public
annotation (Placement(transformation(extent={{100,40},{120,60}})));

protected
final constant Real e(unit = "A.s") = Modelica.Constants.F/Modelica.Constants.N_A
final constant Real e(unit = "C") = Modelica.Constants.F/Modelica.Constants.N_A
"Elementary charge";
final constant Real k(unit = "J/K") = Modelica.Constants.R/Modelica.Constants.N_A
"Boltzmann constant";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ equation

R_sh/R_sh0 = if noEvent(absRadRat > Modelica.Constants.eps) then 1/absRadRat else 0;

// Simplified Power correlations at MPP using lambert W function (Batzelis et al., 2016)
// Simplified power correlations at MPP using Lambert W function (Batzelis et al., 2016)

I_mp = if noEvent(absRadRat <= Modelica.Constants.eps or w<=Modelica.Constants.eps) then 0
else I_ph*(1-1/w)-a*(w-1)/R_sh;
Expand Down
4 changes: 2 additions & 2 deletions IBPSA/Electrical/BaseClasses/PV/PVOpticalAbsRat.mo
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,11 @@ parameter Real tau_0(final unit="1")=exp(-(glaExtCoe*glaThi))*(1 - ((refInd - 1)


equation

// Restriction for zenith angle
zen = if zenAng <= Modelica.Constants.pi/2 then
zenAng
else
Modelica.Constants.pi/2 "Restriction for zenith angle";
Modelica.Constants.pi/2;

//Refraction angle that the incoming irradiation is refracted by due to the glazing
refAng = if noEvent(incAng >= Modelica.Constants.eps and incAng <=
Expand Down

0 comments on commit c17683c

Please sign in to comment.