Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable vm.continuations option for testing #40

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

fengxue-IS
Copy link
Contributor

@fengxue-IS fengxue-IS commented Oct 19, 2022

Depends: adoptium/aqa-tests#4087

Signed-off-by: Jack Lu Jack.S.Lu@ibm.com

Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
@fengxue-IS fengxue-IS marked this pull request as ready for review October 25, 2022 02:27
@fengxue-IS
Copy link
Contributor Author

@LongyuZhang Can you take a look, note this depends on aqa-test changes that disable extended.openjdk tests failures in serviceability suite

Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengxue-IS
Copy link
Contributor Author

@pshipton Can you please take a look.
sanity.openjdk tests related to VirtualThread/Continuation will be re-enabled via adoptium/aqa-tests#4060

@pshipton
Copy link
Member

@fengxue-IS what's the plan for jdk20?

@pshipton pshipton merged commit ac249fd into ibmruntimes:openj9 Oct 25, 2022
@fengxue-IS
Copy link
Contributor Author

@fengxue-IS what's the plan for jdk20?

I will run a grinder to verify if sanity/extended also passes for JDK20, if so, I will port this change to jdknext

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants