Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check private key #64

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Check private key #64

merged 1 commit into from
Jul 14, 2022

Conversation

ZainabF92
Copy link

Fixes: eclipse-openj9/openj9#15413

Signed-off-by: Zainab Fatmi zainab@ibm.com

Signed-off-by: Zainab Fatmi <zainab@ibm.com>
@keithc-ca
Copy link
Member

jenkins test extended.openjdk xlinux jdk18

@pshipton
Copy link
Member

pshipton commented Jul 13, 2022

The original version of this change was ported to jdk19+. Does it also need to be backported? The ECDSAPrvGreaterThanOrder.java test only exists in jdk18+, but the original ECDH key agreement feature was added to jdk8+ and may have the same problem.

@ZainabF92
Copy link
Author

The method ECUtil.checkPrivateKey does not exist prior to jdk18

@pshipton
Copy link
Member

pshipton commented Jul 13, 2022

For the record it was introduced via ca068f817e21fb.

@pshipton
Copy link
Member

jenkins compile amac jdk18

@pshipton
Copy link
Member

extended.openjdk takes a while to run, and the machines aren't setup up correctly to pass all the testing. In particular there is jdk_nio Datagram testing which is running and timing out.

I've run a grinder on all the openjdk sanity/extended testing that looks security related.
testList TESTLIST=jdk_security1,jdk_security2,jdk_security3,jdk_security4,jdk_security_infra,jdk11_tier1_cipher
https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/1130

ECKeyCheck.java is still failing but that is a different known problem eclipse-openj9/openj9#15412
ECDSAPrvGreaterThanOrder.java is passing as expected with this fix.

@keithc-ca keithc-ca merged commit de33403 into ibmruntimes:openj9 Jul 14, 2022
ZainabF92 pushed a commit to ZainabF92/openj9-openjdk-jdk18 that referenced this pull request Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants