-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the OpenSSL PKCS12 method for PBE and simplify NativeCrypto property checking #585
Conversation
src/java.base/share/classes/com/sun/crypto/provider/SunJCE.java
Outdated
Show resolved
Hide resolved
@pshipton @keithc-ca please review - this is related to instanton performance work |
closed/src/java.base/share/classes/jdk/crypto/jniprovider/NativeCrypto.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/jdk/crypto/jniprovider/NativeCrypto.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/jdk/crypto/jniprovider/NativeCrypto.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/jdk/crypto/jniprovider/NativeCrypto.java
Outdated
Show resolved
Hide resolved
src/java.base/share/classes/com/sun/crypto/provider/PKCS12PBECipherCore.java
Outdated
Show resolved
Hide resolved
e56b059
to
cb5552b
Compare
closed/src/java.base/share/classes/jdk/crypto/jniprovider/NativeCrypto.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/jdk/crypto/jniprovider/NativeCrypto.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/jdk/crypto/jniprovider/NativeCrypto.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/jdk/crypto/jniprovider/NativeCrypto.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/jdk/crypto/jniprovider/NativeCrypto.java
Outdated
Show resolved
Hide resolved
02f989b
to
bb770bf
Compare
closed/src/java.base/share/classes/jdk/crypto/jniprovider/NativeCrypto.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/jdk/crypto/jniprovider/NativeCrypto.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/jdk/crypto/jniprovider/NativeCrypto.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/jdk/crypto/jniprovider/NativeCrypto.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/jdk/crypto/jniprovider/NativeCrypto.java
Outdated
Show resolved
Hide resolved
src/java.base/share/classes/com/sun/crypto/provider/PKCS12PBECipherCore.java
Outdated
Show resolved
Hide resolved
5b0344e
to
af0cf21
Compare
Jenkins test sanity alinux64 jdk11 |
For the record, the build has passed and testing is proceeding; see https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJDK11/96/. |
@alon-sh Please indicate your approval or comment otherwise. |
@keithc-ca looks good, please proceed. FYI @vijaysun-omr @tajila this is the perf fix for instanton that was discussed @mstoodle core functionality for FIPS pkcs12 file based keystores |
Please address the failing test (undo the debug message change to say "library" instead of "implementation"
|
…rty checking Signed-off-by: Zainab Fatmi <zainab@ibm.com>
Done |
Jenkins test sanity alinux64 jdk11 |
@ZainabF92 Please a PR for jdk17 and JDKnext as well |
I've already opened up a PR for JDKnext and @WilburZjh is working on the jdk17 PR |
JDK17 PR is opened. |
@ZainabF92 are there plans to get this in jdk8? |
Added native acceleration of the PKCS12 PBE derive method. Created static methods in
NativeCrypto.java
to read the security properties, so that this code is not duplicated across the codebase.Signed-off-by: Zainab Fatmi zainab@ibm.com