Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the OpenSSL PKCS12 method for PBE and simplify NativeCrypto property checking #585

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

ZainabF92
Copy link

@ZainabF92 ZainabF92 commented Oct 14, 2022

Added native acceleration of the PKCS12 PBE derive method. Created static methods in NativeCrypto.java to read the security properties, so that this code is not duplicated across the codebase.

Signed-off-by: Zainab Fatmi zainab@ibm.com

@alon-sh
Copy link
Contributor

alon-sh commented Oct 15, 2022

@pshipton @keithc-ca please review - this is related to instanton performance work

@ZainabF92 ZainabF92 force-pushed the newPBE branch 2 times, most recently from e56b059 to cb5552b Compare October 18, 2022 15:49
@keithc-ca
Copy link
Member

Jenkins test sanity alinux64 jdk11

@keithc-ca
Copy link
Member

For the record, the build has passed and testing is proceeding; see https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJDK11/96/.

@keithc-ca
Copy link
Member

@alon-sh Please indicate your approval or comment otherwise.

@alon-sh
Copy link
Contributor

alon-sh commented Oct 27, 2022

@keithc-ca looks good, please proceed.

FYI @vijaysun-omr @tajila this is the perf fix for instanton that was discussed

@mstoodle core functionality for FIPS pkcs12 file based keystores

@keithc-ca
Copy link
Member

Please address the failing test (undo the debug message change to say "library" instead of "implementation"

 [OUT] Crypto test COMPLETED
 [ERR] Attempt to load OpenSSL /lib64/libcrypto.so.3
 [ERR] Supported OpenSSL version: OpenSSL 3.0.1 14 Dec 2021
 [ERR] MessageDigest - using native crypto implementation.
 [ERR] SunEC - using native crypto implementation.
 [ERR] NativeChaCha20Cipher - using native crypto implementation.
 [ERR] CipherCore (CBC) - using native crypto implementation.
 [ERR] CipherCore (GCM) - using native crypto implementation.
>> Success condition was not found: [Output match: using native crypto library]

…rty checking

Signed-off-by: Zainab Fatmi <zainab@ibm.com>
@ZainabF92
Copy link
Author

Done

@keithc-ca
Copy link
Member

Jenkins test sanity alinux64 jdk11

@keithc-ca keithc-ca merged commit b1f758b into ibmruntimes:openj9 Oct 28, 2022
@tajila
Copy link
Member

tajila commented Oct 28, 2022

@ZainabF92 Please a PR for jdk17 and JDKnext as well

@ZainabF92
Copy link
Author

I've already opened up a PR for JDKnext and @WilburZjh is working on the jdk17 PR

@WilburZjh
Copy link
Contributor

I've already opened up a PR for JDKnext and @WilburZjh is working on the jdk17 PR

JDK17 PR is opened.

@tajila
Copy link
Member

tajila commented Nov 7, 2022

@ZainabF92 are there plans to get this in jdk8?

@ZainabF92
Copy link
Author

Yes, openj9-openjdk-jdk8#630

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants