Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Lambda expression to avoid bootstrap problem #113

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Remove Lambda expression to avoid bootstrap problem #113

merged 1 commit into from
Jan 31, 2019

Conversation

JasonFengJ9
Copy link
Member

@JasonFengJ9 JasonFengJ9 commented Jan 30, 2019 •
edited by pshipton
Loading

Remove Lambda expression to avoid bootstrap problem

When jdk.internal.lambda.dumpProxyClasses is enabled, this triggers Module method calls before java.base is created, and caused null module object is returned and eventually NPE.

Replaced Lambda expression with anonymous class avoid such bootstrap problem.

Related to eclipse-openj9/openj9#3399

Depends on eclipse-openj9/openj9#4533

Reviewer: @pshipton
FYI: @DanHeidinga @hangshao0

Signed-off-by: Jason Feng fengj@ca.ibm.com

@JasonFengJ9 JasonFengJ9 mentioned this pull request Jan 30, 2019
Closed
@pshipton
Copy link
Member

Made a comment eclipse-openj9/openj9#3399 (comment)

@JasonFengJ9 JasonFengJ9 mentioned this pull request Jan 30, 2019
Open
@JasonFengJ9
Remove Lambda expression to avoid bootstrap problem
b8324bd 
When jdk.internal.lambda.dumpProxyClasses is enabled, this triggers
module method calls before java.base is created, and caused null module
object is returned and eventually NPE.

Replaced Lambda expression with anonymous class avoid such bootstrap
problem.

Signed-off-by: Jason Feng <fengj@ca.ibm.com>
@pshipton
Copy link
Member

jenkins test sanity zlinux

@pshipton
Copy link
Member

@JasonFengJ9 please look at the build failure https://ci.eclipse.org/openj9/job/PullRequest-Sanity-JDK11-linux_390-64_cmprssptrs-OpenJDK11/15/

@JasonFengJ9
Copy link
Member Author

JasonFengJ9 commented Jan 31, 2019 •
edited
Loading

The failure was due to the OpenJDK bug identified at eclipse-openj9/openj9#3399 (comment)

11:12:20 Exception in thread "main" java.lang.ExceptionInInitializerError
11:12:20 	at java.base/java.lang.J9VMInternals.ensureError(J9VMInternals.java:191)
11:12:20 	at java.base/java.lang.J9VMInternals.recordInitializationFailure(J9VMInternals.java:180)
11:12:20 	at java.base/com.ibm.tools.attach.target.AttachHandler.initializeAttachAPI(AttachHandler.java:131)
11:12:20 Caused by: java.lang.NullPointerException
11:12:20 	at java.base/jdk.internal.reflect.ReflectionFactory.newMethodAccessor(ReflectionFactory.java:200)
11:12:20 	at java.base/java.lang.reflect.Method.acquireMethodAccessor(Method.java:632)
11:12:20 	at java.base/java.lang.reflect.Method.invoke(Method.java:564)
11:12:20 	at java.base/java.lang.Class.cacheField(Class.java:3950)
11:12:20 	at java.base/java.lang.Class.getDeclaredField(Class.java:901)
11:12:20 	at java.base/java.lang.Class.getEnumVars(Class.java:2906)
11:12:20 	at java.base/java.lang.Class.getEnumConstantsShared(Class.java:2969)
11:12:20 	at java.base/java.lang.Access.getEnumConstantsShared(Access.java:91)
11:12:20 	at java.base/java.util.EnumSet.getUniverse(EnumSet.java:406)
11:12:20 	at java.base/java.util.EnumSet.noneOf(EnumSet.java:109)
11:12:20 	at java.base/java.util.EnumSet.of(EnumSet.java:283)
11:12:20 	at java.base/com.ibm.tools.attach.target.IPC.<clinit>(IPC.java:65)

However it is interesting that this PR triggered this NPE while it didn't hit it before.
Will seek a workaround.

@JasonFengJ9
Copy link
Member Author

I guess this PR changed bootstrap sequence a bit and the fieldjdk/internal/reflect/ReflectionFactory.langReflectAccess was referenced before a similar call but with correct method jdk/internal/reflect/ReflectionFactory.langReflectAccess() was made.
Will add a call Modifier.isPublic(Modifier.PUBLIC); in J9JCL code to initialize the fieldjdk/internal/reflect/ReflectionFactory.langReflectAccess.

@JasonFengJ9 JasonFengJ9 mentioned this pull request Jan 31, 2019
Merged
@pshipton
Copy link
Member

Tested via eclipse-openj9/openj9#4533

@pshipton pshipton merged commit 14c9739 into ibmruntimes:openj9 Jan 31, 2019
hangshao0 pushed a commit to hangshao0/openj9-openjdk-jdk11 that referenced this pull request Aug 7, 2019
@pshipton
Merge pull request ibmruntimes#113 from Graham-Chapman/openj9-jdk
eeabecc 
Remove references to libffi shared libary
@JasonFengJ9 JasonFengJ9 deleted the loggen branch October 9, 2019 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshipton pshipton pshipton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JasonFengJ9 @pshipton