-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore behavior on platforms where CRIU is supported but not in use #717
Conversation
68b90b5
to
9d06afc
Compare
This is to fix eclipse-openj9/openj9#18602 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the commit message and the summary here could be improved. Rather than describe how the problem was fixed, explain what problem is fixed.
src/java.base/unix/classes/sun/security/provider/NativePRNG.java
Outdated
Show resolved
Hide resolved
We'll also want a copy of this (once finalized) for https://github.com/ibmruntimes/openj9-openjdk-jdk22. |
9d06afc
to
9c278fc
Compare
The content looks good, but it doesn't appear that you've addressed my concern about the commit message or the summary here. From my perspective, the essence of this is to restore the behavior (actually read random data) on platforms where CRIU is supported, but not in use. |
Yes, I just updated the code. Now Im updating the commit message. |
This PR aims to fix an issue on how to read random data and get random bytes on platforms where CRIU is supported, but not in use by enabling it via a --enable-criu-support JVM option.
9c278fc
to
b8aa39e
Compare
I see the commit message was updated. Is this ready to be removed from draft state? |
I rerun the failed tests on the initial code without using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, assuming testing will be successful.
The change looked correct so I went ahead and merged it for jdk21 and we started a Semeru 0.42 M3 build, which is looking (very) good. |
Build is passed, and the failed cases are passed. Change from draft to ready for review. @jasonkatonica FYI |
Update RestrictedSecurity flags, alter debug comments and profile name
This PR aims to fix an issue on how to read random data and
get random bytes on platforms where CRIU is supported, but
not in use by enabling it via a --enable-criu-support JVM
option.
Issue eclipse-openj9/openj9#18602