Run virtual/stress/Skynet with -Xnocompressedrefs #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
JDK21 backport: ibmruntimes/openj9-openjdk-jdk21#53 fyi @pshipton @tajila @fengxue-IS This should allow us to enable the Skynet Benchmark. Will set this ready for review once eclipse-openj9/openj9#18251 is merged. |
babsingh
force-pushed
the
fix_skynet_jdknext
branch
from
f8f544a
to
091a0db
Compare
babsingh
added a commit
to babsingh/aqa-tests
that referenced
this pull request
Oct 6, 2023
Depends on eclipse-openj9/openj9#18251 Depends on ibmruntimes/openj9-openjdk-jdk21#53 Depends on ibmruntimes/openj9-openjdk-jdk#675 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
added a commit
to babsingh/aqa-tests
that referenced
this pull request
Oct 6, 2023
- Depends on eclipse-openj9/openj9#18251 - Depends on ibmruntimes/openj9-openjdk-jdk21#53 - Depends on ibmruntimes/openj9-openjdk-jdk#675 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
added a commit
to babsingh/aqa-tests
that referenced
this pull request
Oct 6, 2023
- Depends on eclipse-openj9/openj9#18251 - Depends on ibmruntimes/openj9-openjdk-jdk21#53 - Depends on ibmruntimes/openj9-openjdk-jdk#675 - Related: eclipse-openj9/openj9#16728 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
This was referenced Oct 6, 2023
|
eclipse-openj9/openj9#18251 has been merged. @pshipton Requesting your review. |
pshipton
reviewed
Oct 16, 2023
Skynet is a stress benchmark, which exceeds the below 4G capacity of -Xcompressedrefs. The current workaround is to use -Xnocompressedrefs where memory can be allocated outside the 4G boundary. To run Skynet with -Xcompressedrefs, the following features will be needed: - Move unmounted continuation stacks out of the low memory area. - Improve performance of the sub-4G allocator so that it doesn't regress under high memory usage. Depends on eclipse-openj9/openj9#18251 Related: eclipse-openj9/openj9#16728 Related: eclipse-openj9/openj9#15781 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
force-pushed
the
fix_skynet_jdknext
branch
from
091a0db
to
8ccfe36
Compare
pshipton
approved these changes
Oct 16, 2023
llxia
pushed a commit
to adoptium/aqa-tests
that referenced
this pull request
Oct 17, 2023
- Depends on eclipse-openj9/openj9#18251 - Depends on ibmruntimes/openj9-openjdk-jdk21#53 - Depends on ibmruntimes/openj9-openjdk-jdk#675 - Related: eclipse-openj9/openj9#16728 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
llxia
pushed a commit
to llxia/aqa-tests
that referenced
this pull request
Nov 22, 2023
- Depends on eclipse-openj9/openj9#18251 - Depends on ibmruntimes/openj9-openjdk-jdk21#53 - Depends on ibmruntimes/openj9-openjdk-jdk#675 - Related: eclipse-openj9/openj9#16728 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
llxia
pushed a commit
to llxia/aqa-tests
that referenced
this pull request
Nov 22, 2023
- Depends on eclipse-openj9/openj9#18251 - Depends on ibmruntimes/openj9-openjdk-jdk21#53 - Depends on ibmruntimes/openj9-openjdk-jdk#675 - Related: eclipse-openj9/openj9#16728 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
pshipton
pushed a commit
to adoptium/aqa-tests
that referenced
this pull request
Nov 22, 2023
- Depends on eclipse-openj9/openj9#18251 - Depends on ibmruntimes/openj9-openjdk-jdk21#53 - Depends on ibmruntimes/openj9-openjdk-jdk#675 - Related: eclipse-openj9/openj9#16728 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
tajila
pushed a commit
to tajila/openj9-openjdk-jdk
that referenced
this pull request
Mar 27, 2024
Fix javadoc violations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skynet is a stress benchmark, which exceeds the below 4G capacity
of
-Xcompressedrefs. The current workaround is to use-Xnocompressedrefswhere memory can be allocated outside the 4Gboundary.
To run Skynet with
-Xcompressedrefs, the following features will beneeded:
regress under high memory usage.
Depends on eclipse-openj9/openj9#18251
Related: eclipse-openj9/openj9#16728
Related: eclipse-openj9/openj9#15781
Signed-off-by: Babneet Singh sbabneet@ca.ibm.com