[Jtreg]Fix the issue with addVarg/nextVarg of VaList on Power #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code is the same as ibmruntimes/openj9-openjdk-jdk19#42. |
ChengJin01
force-pushed
the
jep424_fix_valist_struct_jtreg_tests_jdknext
branch
from
0238811
to
3c78478
Compare
added 2 commits
October 25, 2022 16:08
The change is to resolve the Jtreg test related issue with addVarg/nextVarg of VaList on Power to ensure the struct value is correctly read from va_list and added to va_list when the struct argument size is inconsistent with its layout size. Signed-off-by: Cheng Jin <jincheng@ca.ibm.com>
The change is to resolve the Jtreg test related issue with addVarg/nextVarg of VaList on Power to ensure the struct value is correctly read from va_list and added to va_list when the struct argument size is inconsistent with its layout size. Signed-off-by: Cheng Jin <jincheng@ca.ibm.com>
ChengJin01
force-pushed
the
jep424_fix_valist_struct_jtreg_tests_jdknext
branch
from
3c78478
to
7771470
Compare
tajila
approved these changes
Oct 26, 2022
|
jenkins test sanity plinux jdknext |
keithc-ca
reviewed
Nov 3, 2022
Comment on lines
+164
to
+165
| return (structSegment.byteSize() > structArgLayout.byteSize()) ? | ||
| structArgLayout.byteSize() : structSegment.byteSize(); |
There was a problem hiding this comment.
Am I missing something or could this just be this?
return Math.min(structSegment.byteSize(), structArgLayout.byteSize());
There was a problem hiding this comment.
We expect to get the smaller size suitable for the struct to allocate, in such case Math.min() should work. I will create a PR for this minor adjustment.
There was a problem hiding this comment.
PRs are created at #521 and ibmruntimes/openj9-openjdk-jdk19#49.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is to resolve the Jtreg test related issue with addVarg/nextVarg of VaList on Power to ensure the struct value is correctly read from va_list and added to va_list when the struct argument size is inconsistent with its layout size.
Signed-off-by: Cheng Jin jincheng@ca.ibm.com