Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add owner path attribute #276

Merged
merged 2 commits into from
Oct 18, 2024
Merged

feat: add owner path attribute #276

merged 2 commits into from
Oct 18, 2024

Conversation

IgnacioBecerra
Copy link
Contributor

@IgnacioBecerra IgnacioBecerra commented Oct 16, 2024 •
edited
Loading

Closes https://github.com/ibm-telemetry/telemetry-internal/issues/201

Changelog

New

  • added analyzed.owner.path attribute to the collected project attributes

Changed

  • updated test snapshots
  • updated @ibm/telemetry-attributes-js to v4.1.1

Testing / reviewing

ran npm run test

mattrosno
mattrosno approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@mattrosno mattrosno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we able to test this against staging prior to publishing to npm?

@IgnacioBecerra
Copy link
Contributor Author

@mattrosno yes i believe so! should be just like we've been testing with the endpoint

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
66.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@IgnacioBecerra IgnacioBecerra merged commit 8104803 into main Oct 18, 2024
6 checks passed
@IgnacioBecerra IgnacioBecerra deleted the add-owner-path-attribute branch October 18, 2024 20:51
@telemmy telemmy bot mentioned this pull request Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattrosno mattrosno mattrosno approved these changes

@ariellalgilmore ariellalgilmore ariellalgilmore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IgnacioBecerra @mattrosno @ariellalgilmore