1120 Trace URI on CRITICAL message Response #1323
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abiasojo
force-pushed
the
1120-criticalmsgrspnocntnt
branch
from
106e863 to
377de0e
Compare
baemyung
reviewed
Jun 19, 2025
http/http2_connection.hpp
Outdated
| @@ -207,7 +207,8 @@ class HTTP2Connection : | |||
|
|
|||
| completeResponseFields(stream.accept, res); | |||
| res.addHeader(boost::beast::http::field::date, getCachedDateStr()); | |||
| res.preparePayload(); | |||
| crow::Request& thisReq = *it->second.req; | |||
| res.preparePayload(thisReq.url().path()); | |||
There was a problem hiding this comment.
L204 already has this
Http2StreamData& stream = it->second;
So, these L210-L211 can be like
res.preparePayload(stream->url().path());
There was a problem hiding this comment.
It would be
res.preparePayload(stream.req->url().path());
http/http_response.hpp
Outdated
| @@ -186,7 +186,7 @@ struct Response | |||
| return response.body().payloadSize(); | |||
| } | |||
|
|
|||
| void preparePayload() | |||
| void preparePayload(std::string_view s) | |||
There was a problem hiding this comment.
I think the argument can be more readable like
void preparePayload(std::string_view url)
http/http_response.hpp
Outdated
| "allowed to have a body", | ||
| logPtr(this)); | ||
| "allowed to have a body \"{}\"", | ||
| logPtr(this), s); |
There was a problem hiding this comment.
Would it be better to specify url like this?
"allowed to have a body, for url {}",
|
Will want to go upstream here |
Trace URI on CRITICAL message Response content provided but code
was no-content or not_modified.
curl -k -H "X-Auth-Token: $bmc_token" -H "Content-Type: application/json" -X PATCH -d '{"LocationIndicatorActive":true}' https://$bmc/redfish/v1/Managers/bmc
curl -k -H "Content-Type: application/json" -d '{"PowerRestorePolicy":"LastState"}' -X PATCH https://${bmc}/redfish/v1/Systems/system
root@p10bmc:~# journalctl | grep 'Response content'
Jun 19 16:51:33 p10bmc bmcwebd[1034]: [http_response.hpp:213] 0xb75210 Response content provided but code was no-content or not_modified, which aren't allowed t
o have a body for url : "/redfish/v1/Managers/bmc"
Jun 19 16:52:00 p10bmc bmcwebd[1034]: [http_response.hpp:213] 0xb75210 Response content provided but code was no-content or not_modified, which aren't allowed t
o have a body for url : "/redfish/v1/Systems/system"
Signed-off-by: Abiola Asojo <abiola.asojo@ibm.com>
abiasojo
force-pushed
the
1120-criticalmsgrspnocntnt
branch
from
377de0e to
2d85598
Compare
jeaaustx
approved these changes
Jun 19, 2025
baemyung
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trace URI on CRITICAL message Response content provided but code was no-content or not_modified.