fix getMaxSCOLength to take into account MQSCO_VERSION_7 #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for finding this. I've added a check to the release process so this kind of error won't happen again. |
|
Hi @ibmmqmet, any idea about when this is going to be released? |
|
It'll come out with the next MQ CD release. Whose planned date I can't put here. |
ibmmqmet
added a commit
that referenced
this pull request
Feb 27, 2025
- ibmmq - Add function to map PCF attribute values to strings - ibmmq - Interpret more PCF types (the filters) - ibmmq - MaxSCOLength fix - PR #216 - ibmmq - Add MQIGolangVersion function - ibmmq - Handle MQ C client callbacks with wrong hObj (#217) - mqmetric - Ignore the EXTENDED queue metrics unless explicitly enabled - mqmetric - Deal with possible duplication of metrics between QSTATUS and published QSTAT values Without this change, Prometheus (at least) will panic. The system topic metrics were extended in MQ 9.4.2 and potentially in various fixpacks for older LTS releases; this version of the collector code is required once you reach those qmgr levels. - mqmetric - Recognise Native HA Cross-region replication metrics - ibmmqotel - Fix concurrent maps (#218) - samples - Modify amqspcf.go to use PCF mapping functions - samples - Ensure Dockerfile examples do not pull base images from Dockerhub - samples - Remove unnecessary (incorrect) declarations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure all items are complete before opening.
What
Updated
getMaxSCOLengthto takeMQSCO_VERSION_7into accountHow
This is a bug:
freeHTTPSKeyStoretries to free this data, but because the C SCO structure isn't big enough, it tries to free memory from outside the structureTesting
I did not test this.
Issues
Links to the github issue(s) (if present) that this pull request is resolving.