Added unit tests for SampleEnvSetter. #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
harshitsharma2801
commented
Apr 8, 2024
harshitsharma2801
commented
- Added Junit5 to POM.XML
- Added maven-surefire-plugin to run tests on every build
- POM.XML was formatted by a XML Formatter
- Added a setter to set mqEndpoints to mock and test the endpoints from SampleEnvSetterTest.
chughts
requested changes
Apr 9, 2024
| @@ -233,4 +233,8 @@ public int getCount() { | |||
| // need to come from a CCDT and environment settings | |||
| return (null == mqEndPoints) ? 1 : mqEndPoints.length(); | |||
| } | |||
|
|
|||
| public void setMqEndpoints(JSONArray mqEndPoints){ | |||
There was a problem hiding this comment.
Adding a function just to test it!
Remove this function, we should be testing the functions that already exist, and are being used.
|
chughts
requested changes
Apr 15, 2024
| static SampleEnvSetter envSetter; | ||
|
|
||
| @BeforeAll | ||
| public static void setUp() throws NoSuchFieldException, IllegalAccessException{ |
There was a problem hiding this comment.
I don't think we should be mocking the endpoints. The point of the test is to verify:
- That the env setter is able to read the file, whose name and location are specified by an environment variable.
- That it allows overrides via environment variables.
- How it behaves when there are missing values in the env file.
- How it behaves when the file can't be found.
chughts
requested changes
Apr 17, 2024
| int value = envSetter.getPortEnvValue("PORT", 0); | ||
| assertEquals(1415 , value); | ||
| assertNotNull(value); | ||
|
|
||
| //Test for default port given invalid port key | ||
| value = envSetter.getPortEnvValue("INVALID_PORT", 0); |
There was a problem hiding this comment.
why is INVALID_PORT returning 1414 ?
There was a problem hiding this comment.
The function returns the default port if the key is not found.
chughts
requested changes
Apr 18, 2024
| @@ -22,13 +22,13 @@ | |||
|
|
|||
| public class SampleEnvSetterTest { | |||
|
|
|||
| static SampleEnvSetter envSetter; | |||
| private static SampleEnvSetter envSetter; | |||
| private static final String ENV_FILE = "EnvFile"; | |||
There was a problem hiding this comment.
These are no longer use, they can be removed.
chughts
approved these changes
Apr 18, 2024
rcoppen
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.