[patch] Update DNS entries for Visual Inspection path-based routing support

[anujkabraibm2022]

Move visualinspection DNS entries into routing mode conditional blocks to support both path-based and subdomain-based routing configurations.

Changes:

• Move visualinspection nowildcard entries into path routing conditional
• Move *.visualinspection wildcard entry into subdomain routing conditional
• Applies to both suite_certs and suite_dns role templates

Description

https://jsw.ibm.com/browse/MASMVI-3150

[dixitgsathwara]

Looks Good To Me

[durera]

This file (not specifically your changes) is very confusing and doesn't look right to me -- e.g.

  -  {{ mas_workspace_id }}.health
  - health
  -  {{ mas_workspace_id }}-all.health
  -  {{ mas_workspace_id }}-ui.health
  -  {{ mas_workspace_id }}-mea.health
  -  {{ mas_workspace_id }}-rpt.health
  -  {{ mas_workspace_id }}-cron.health
  -  {{ mas_workspace_id }}-jms.health
  - maxinst.health
  - messaging.iot
  -  {{ mas_workspace_id }}.messaging.iot

These aren't gated by pathbased routing if/else?

To simplify this, please break this into two files:

• dnsentries-path.yml.j2
• dnsentries-subdomain.yml.j2

This way it will be much clearer to the reader what routes are set up in each mode.

Coordinate the changes with @IanBoden if needed

[anujkabraibm2022]

This file (not specifically your changes) is very confusing and doesn't look right to me -- e.g.

  -  {{ mas_workspace_id }}.health
  - health
  -  {{ mas_workspace_id }}-all.health
  -  {{ mas_workspace_id }}-ui.health
  -  {{ mas_workspace_id }}-mea.health
  -  {{ mas_workspace_id }}-rpt.health
  -  {{ mas_workspace_id }}-cron.health
  -  {{ mas_workspace_id }}-jms.health
  - maxinst.health
  - messaging.iot
  -  {{ mas_workspace_id }}.messaging.iot

These aren't gated by pathbased routing if/else?

To simplify this, please break this into two files:

• dnsentries-path.yml.j2
• dnsentries-subdomain.yml.j2

This way it will be much clearer to the reader what routes are set up in each mode.

Coordinate the changes with @IanBoden if needed

@durera as Ian respond I think we're best off getting this change in and then chasing the remaining domains then splitting the file out once we are happy