[minor] add external-secrets operator ansible role with helm deployment#2256
Open
terc1997 wants to merge 4 commits into
Open
[minor] add external-secrets operator ansible role with helm deployment#2256terc1997 wants to merge 4 commits into
terc1997 wants to merge 4 commits into
Conversation
durera
reviewed
May 23, 2026
Contributor
durera
left a comment
There was a problem hiding this comment.
We need to see it working end-to-end with a generated secret containing content from our secrets-manager.
e.g. I added some code from the other branch for the clustersecretstore and ran a quick test and this is as far as I got:
oc -n default get externalsecret example-arbitrary-secret -o yaml
apiVersion: external-secrets.io/v1
kind: ExternalSecret
metadata:
annotations:
kubectl.kubernetes.io/last-applied-configuration: |
{"apiVersion":"external-secrets.io/v1","kind":"ExternalSecret","metadata":{"annotations":{},"name":"example-arbitrary-secret","namespace":"default"},"spec":{"data":[{"remoteRef":{"key":"ibmcloud-apikey"},"secretKey":"IBMCLOUD_APIKEY"}],"refreshInterval":"1h","secretStoreRef":{"kind":"ClusterSecretStore","name":"ibm-secrets-manager"},"target":{"creationPolicy":"Owner","name":"my-secrets"}}}
creationTimestamp: "2026-05-23T11:20:30Z"
finalizers:
- externalsecrets.external-secrets.io/externalsecret-cleanup
generation: 1
name: example-arbitrary-secret
namespace: default
resourceVersion: "1065400"
uid: 0d29efbb-063b-43dd-b0d6-db25a8c0bc94
spec:
data:
- remoteRef:
conversionStrategy: Default
decodingStrategy: None
key: ibmcloud-apikey
metadataPolicy: None
nullBytePolicy: Ignore
secretKey: IBMCLOUD_APIKEY
refreshInterval: 1h
secretStoreRef:
kind: ClusterSecretStore
name: ibm-secrets-manager
target:
creationPolicy: Owner
deletionPolicy: Retain
name: my-secrets
status:
binding:
name: ""
conditions:
- lastTransitionTime: "2026-05-23T11:20:30Z"
message: could not get secret data from provider
reason: SecretSyncedError
status: "False"
type: Ready
refreshTime: null
We don't need the to to support creating the secrets itself (just the operator install + the store creation)
| webhook: | ||
| replicaCount: 2 | ||
| roles: | ||
| - ibm.mas_devops.external-secrets |
Contributor
There was a problem hiding this comment.
Various places where the role name is incorrect (- instead of _)
|
|
||
| **Purpose**: Determines whether to install or uninstall the External Secrets Operator. | ||
|
|
||
| **When to use**: |
Contributor
There was a problem hiding this comment.
we need the role able to create/delete secretstores per:
- https://github.com/ibm-mas/ansible-devops/tree/external-secrets/ibm/mas_devops/roles/external_secrets#eso_action
- https://github.com/ibm-mas/ansible-devops/blob/external-secrets/ibm/mas_devops/roles/external_secrets/tasks/create-clustersecretstore.yml, https://github.com/ibm-mas/ansible-devops/blob/external-secrets/ibm/mas_devops/roles/external_secrets/tasks/create-secretstore.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce the installation of the External Secrets Operator in our ansible-devops collection. Supports install and uninstalls
Test Results