Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop using CDN to pull monaco-editor's loader.js #808

Merged
merged 1 commit into from
Apr 2, 2018

Conversation

starpit
Copy link
Member

@starpit starpit commented Apr 2, 2018

Fixes #807

@codecov-io
Copy link

Codecov Report

Merging #808 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #808      +/-   ##
==========================================
- Coverage   83.36%   83.34%   -0.03%     
==========================================
  Files          99       99              
  Lines        8501     8501              
==========================================
- Hits         7087     7085       -2     
- Misses       1414     1416       +2
Impacted Files Coverage Δ
app/plugins/modules/editor/lib/edit.js 88.19% <100%> (ø) ⬆️
app/plugins/modules/wskflow/lib/graph2doms.js 62.98% <0%> (-0.82%) ⬇️
app/content/js/repl.js 91.59% <0%> (-0.62%) ⬇️
...ins/modules/activation-visualizations/lib/table.js 95.14% <0%> (+1.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81526ca...bcd819e. Read the comment docs.

@starpit starpit merged commit 13516bb into ibm-functions:master Apr 2, 2018
@starpit starpit deleted the fix_807 branch April 2, 2018 16:44
@starpit starpit restored the fix_807 branch April 2, 2018 18:51
@starpit starpit deleted the fix_807 branch April 2, 2018 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants