test: error when sqlglot tells us a compilation is unsupported #11772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Wow, I am surprised that only 2 backends failed with this enabled! |
Contributor
Author
|
@cpcloud if I fix those failing tests then does this seem like a good idea? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sanity check. If sqlglot tells us we are generating invalid SQL, then we should be handling it better.
I'm not sure how CI will like this. Potentially this will reveal a lot of bad assumptions we have been making.
My other motivation here is that if we merge this, then we can push more logic down into SQLglot. For example, if tobymao/sqlglot#6377 gets merged, then we can rely on sqlglot to tell us that
column.first(include_nulls=False)is illegal to compile on postgres (onlycolumn.first(include_nulls=True)is possible to correctly compile. Currently, we have to do these sorts of checks in our individual backend compilers, for example see #11311