-
Notifications
You must be signed in to change notification settings - Fork 86
[Discounts] Configuration #2781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: discounts-rest
Are you sure you want to change the base?
Conversation
de5af4e
to
f2104e8
Compare
Preview of modified filesPreview of modified Markdown: |
b3ca350
to
03e08d8
Compare
03e08d8
to
eb9047b
Compare
eb9047b
to
09fed3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor grammar and var usage (I'm pretty sure [[[= var =]]](url)
case was previously studied before as working) to fix but approvable as a whole
docs/discounts/install_discounts.md
Outdated
@@ -8,7 +8,7 @@ editions: | |||
|
|||
# Install Discounts | |||
|
|||
Discounts are available as an LTS update to [[= product_name_com =]], starting with version v4.6.19 or higher. | |||
Discounts are available as an LTS update to [Ibexa Commerce](ibexa_commerce.md), starting with version v4.6.19 or higher. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discounts are available as an LTS update to [Ibexa Commerce](ibexa_commerce.md), starting with version v4.6.19 or higher. | |
Discounts are available as an LTS update to [[[= product_name_com =]]](ibexa_commerce.md), starting with version v4.6.19 or higher. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't work with the "magic autolink" plugin, I had to do it like this: 30e78d9
But thank you for the suggestion, I think it's better than hardcoding the name here.
Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>
This PR extracts the Discounts configuration, describing options from:
and the previously described pagination options.