Skip to content

[Discounts] Configuration #2781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: discounts-rest
Choose a base branch
from
Open

Conversation

mnocon
Copy link
Contributor

@mnocon mnocon commented Jun 10, 2025

This PR extracts the Discounts configuration, describing options from:

and the previously described pagination options.

@mnocon mnocon force-pushed the discounts-configuration branch from de5af4e to f2104e8 Compare June 10, 2025 16:57
Copy link

github-actions bot commented Jun 10, 2025

Preview of modified files

Preview of modified Markdown:

@mnocon mnocon force-pushed the discounts-configuration branch from b3ca350 to 03e08d8 Compare June 11, 2025 06:37
@mnocon mnocon marked this pull request as ready for review June 11, 2025 06:40
@mnocon mnocon requested review from Steveb-p and konradoboza June 11, 2025 06:40
@mnocon mnocon requested a review from a team June 11, 2025 07:12
@ezrobot ezrobot requested review from adriendupuis, dabrt and julitafalcondusza and removed request for a team June 11, 2025 07:12
@mnocon mnocon force-pushed the discounts-configuration branch from 03e08d8 to eb9047b Compare June 11, 2025 07:54
@mnocon mnocon force-pushed the discounts-configuration branch from eb9047b to 09fed3a Compare June 11, 2025 11:10
Copy link
Contributor

@adriendupuis adriendupuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor grammar and var usage (I'm pretty sure [[[= var =]]](url) case was previously studied before as working) to fix but approvable as a whole

@@ -8,7 +8,7 @@ editions:

# Install Discounts

Discounts are available as an LTS update to [[= product_name_com =]], starting with version v4.6.19 or higher.
Discounts are available as an LTS update to [Ibexa Commerce](ibexa_commerce.md), starting with version v4.6.19 or higher.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Discounts are available as an LTS update to [Ibexa Commerce](ibexa_commerce.md), starting with version v4.6.19 or higher.
Discounts are available as an LTS update to [[[= product_name_com =]]](ibexa_commerce.md), starting with version v4.6.19 or higher.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't work with the "magic autolink" plugin, I had to do it like this: 30e78d9

But thank you for the suggestion, I think it's better than hardcoding the name here.

mnocon and others added 2 commits June 13, 2025 10:02
Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants