Skip to content

IBX-9904: Workflow to build API refs into new PR #2723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
May 13, 2025
Merged

Conversation

adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Apr 30, 2025

Question Answer
JIRA Ticket IBX-9904
Versions 5.0, 4.6
Edition Commerce

Create a workflow that can be triggered to build

  • PHP API Reference on 4.6 and 5.0
  • REST API Reference on 5.0 (TODO)

Will be triggered when a Commerce release is tagged: ibexa/commerce-skeleton#5

Tested with manual triggering gh workflow run api_refs.yaml --ref api-refs-workflow -f version='v4.6.x'
Successfully created PR: #2740

Uses peter-evans/create-pull-request

TODO: In another PR, make the API builder 5.0/REST ready and edit the workflow to commit the REST API Ref as well.

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

Copy link

Preview of modified files: no change to preview.

@adriendupuis adriendupuis changed the title Draft workflow to open API refs PR IBX-9904: Workflow to build API refs into new PR Apr 30, 2025
uses: actions/checkout@v4

- name: Build API Refs
# TODO: On 5.0, update tool to handle both PHP & REST APIs
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To do this, few lines can be added to the 5.0 version of phpdoc.sh:

$PHP_BINARY bin/console ibexa:openapi --yaml > openapi.yaml
redocly build-docs openapi.yaml --output $(realpath $OUTPUT_DIR/../../rest_api/rest_api_reference/rest_api_reference.html)

Anyway, the tool should be renamed and reworked to reflect its new task of building both references.

Switched to a new branch 'api_refs_v4.6.x'
Author identity unknown

*** Please tell me who you are.

Run

  git config --global user.email "you@example.com"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.
fatal: The current branch api_refs_v4.6.x has no upstream branch.
To push the current branch and set the remote as upstream, use
    git push --set-upstream origin api_refs_v4.6.x
@adriendupuis adriendupuis mentioned this pull request May 7, 2025
@adriendupuis adriendupuis mentioned this pull request May 7, 2025
7 tasks
@adriendupuis adriendupuis mentioned this pull request May 12, 2025
@adriendupuis adriendupuis mentioned this pull request May 12, 2025
@adriendupuis adriendupuis mentioned this pull request May 12, 2025
This was referenced May 13, 2025
@adriendupuis adriendupuis marked this pull request as ready for review May 13, 2025 11:56
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! 🙇

@adriendupuis adriendupuis merged commit 6101dfe into master May 13, 2025
6 of 7 checks passed
@adriendupuis adriendupuis deleted the api-refs-workflow branch May 13, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants