-
Notifications
You must be signed in to change notification settings - Fork 86
IBX-9904: Workflow to build API refs into new PR #2723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview of modified files: no change to preview. |
.github/workflows/api_refs.yaml
Outdated
uses: actions/checkout@v4 | ||
|
||
- name: Build API Refs | ||
# TODO: On 5.0, update tool to handle both PHP & REST APIs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To do this, few lines can be added to the 5.0 version of phpdoc.sh:
$PHP_BINARY bin/console ibexa:openapi --yaml > openapi.yaml
redocly build-docs openapi.yaml --output $(realpath $OUTPUT_DIR/../../rest_api/rest_api_reference/rest_api_reference.html)
Anyway, the tool should be renamed and reworked to reflect its new task of building both references.
This reverts commit 530cb71.
Switched to a new branch 'api_refs_v4.6.x' Author identity unknown *** Please tell me who you are. Run git config --global user.email "you@example.com" git config --global user.name "Your Name" to set your account's default identity. Omit --global to set the identity only in this repository.
fatal: The current branch api_refs_v4.6.x has no upstream branch. To push the current branch and set the remote as upstream, use git push --set-upstream origin api_refs_v4.6.x
This reverts commit 16fd5be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you! 🙇
Create a workflow that can be triggered to build
Will be triggered when a Commerce release is tagged: ibexa/commerce-skeleton#5
Tested with manual triggering
gh workflow run api_refs.yaml --ref api-refs-workflow -f version='v4.6.x'
Successfully created PR: #2740
Uses peter-evans/create-pull-request
TODO: In another PR, make the API builder 5.0/REST ready and edit the workflow to commit the REST API Ref as well.
Checklist