Skip to content

IBX-9902: PHP API Ref: Support new PHP features #2709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Apr 29, 2025
Merged

IBX-9902: PHP API Ref: Support new PHP features #2709

merged 18 commits into from
Apr 29, 2025

Conversation

adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Apr 17, 2025 •
edited
Loading

Question Answer
JIRA Ticket IBX-9902
Versions 4.6, 5.0, master
Edition

Add and design new PHP features used a bit in 4.6 and more in 5.0

See #2712 for 4.6 HTML
See #2711 for 5.0 HTML

TODO: Merge #2712 before #2709

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

@github-actions GitHub Actions
Copy link

Preview of modified Markdown: no Markdown change to preview.

@adriendupuis adriendupuis mentioned this pull request Apr 17, 2025
Draft
7 tasks
@adriendupuis adriendupuis mentioned this pull request Apr 18, 2025
Merged
7 tasks
@adriendupuis adriendupuis marked this pull request as ready for review April 21, 2025 11:38
This was referenced Apr 22, 2025
Draft
Merged
@adriendupuis adriendupuis mentioned this pull request Apr 23, 2025
Merged
9 tasks
@adriendupuis adriendupuis marked this pull request as draft April 23, 2025 15:25
@github-actions GitHub Actions
Copy link

Preview of modified files: no change to preview.

@adriendupuis adriendupuis changed the title PHP API Ref: Support new PHP features IBX-9902: PHP API Ref: Support new PHP features Apr 24, 2025
@adriendupuis adriendupuis marked this pull request as ready for review April 25, 2025 07:46
@adriendupuis adriendupuis requested a review from mnocon April 25, 2025 13:38
mnocon
mnocon approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one small remark about read-only spelling that we can discuss 😄

adriendupuis and others added 2 commits April 29, 2025 09:54
@adriendupuis @mnocon
Update tools/php_api_ref/.phpdoc/template/components/class-title.html…
963b310 
….twig

Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com>
@adriendupuis
IBX-9902: PHP API Ref: Support new PHP features: HTML (#2712)
1f728cc 
* Generate PHP API Ref HTML
@adriendupuis adriendupuis merged commit 9fa74a9 into master Apr 29, 2025
4 of 6 checks passed
@adriendupuis adriendupuis deleted the extend-phpdoc-coverage branch April 29, 2025 10:58
adriendupuis added a commit that referenced this pull request Apr 29, 2025
@adriendupuis @mnocon
IBX-9902: PHP API Ref: Support new PHP features (#2709)
3c2c35f 
* Add enum
* Add attributes
* Add `readonly` and `final`
* IBX-9902: PHP API Ref: Support new PHP features: HTML (#2712)

---------

Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com>
(cherry picked from commit 9fa74a9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnocon mnocon mnocon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adriendupuis @mnocon