Skip to content

Conversation

@MagdalenaZuba
Copy link
Contributor

@MagdalenaZuba MagdalenaZuba commented Jul 7, 2023

Question Answer
JIRA Ticket https://issues.ibexa.co/browse/IBX-5710
Versions 4.6
Edition N/A

Added templates to:

  • GET /shipments (ibexa/shipping#29)
  • GET /shipments/{identifier}
  • PATCH /shipments/{identifier}
  • GET /shipping/methods (ibexa/shipping#25)
  • GET /shipping/methods/{identifier}
  • GET /shipping/method-types (ibexa/shipping#24)
  • GET /shipping/method-types/{identifier}
  • GET /orders/order/{identifier}/shipments (ibexa/shipping#29)

TODO:

  • Rebuild rest_api_reference.html one last time before merge

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

@adamwojs adamwojs changed the title IBX-5710 Shipping REST API IBX-5710: Shipping REST API Jul 13, 2023
@alongosz alongosz self-assigned this Aug 31, 2023
@adamwojs
Copy link
Member

adamwojs commented Oct 5, 2023

@MagdalenaZuba rebase is needed here

@MagdalenaZuba
Copy link
Contributor Author

@adamwojs this PR is marked as work in progress, I just provided skeleton, Andrew took over on Aug 31 and will provide examples and fill in missing information as well as perform rebase

@adamwojs adamwojs marked this pull request as draft October 5, 2023 07:55
@adamwojs
Copy link
Member

adamwojs commented Oct 5, 2023

I've converted it to a draft in order to skip going through this PR next time 😉

@adriendupuis adriendupuis self-assigned this Oct 12, 2023
@adriendupuis adriendupuis marked this pull request as ready for review December 11, 2023 12:41
@adriendupuis adriendupuis requested a review from alongosz January 19, 2024 11:53
@alongosz alongosz requested a review from a team January 19, 2024 12:01
@adriendupuis adriendupuis removed the request for review from a team February 7, 2024 10:50
Co-authored-by: Tomasz Dąbrowski <64841871+dabrt@users.noreply.github.com>
@adriendupuis adriendupuis requested a review from dabrt February 8, 2024 08:40
@adriendupuis adriendupuis added the Wait with merge PRs that shouldn't be merged instantly label Feb 8, 2024
@adriendupuis
Copy link
Contributor

Probably ready to merge but wait for #2289 which will remove the pollution of unrelated entries.

# Conflicts:
#	docs/api/rest_api/rest_api_reference/rest_api_reference.html
@adriendupuis adriendupuis merged commit 3309727 into master Feb 12, 2024
@adriendupuis adriendupuis deleted the shipment_rest_api branch February 12, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs DOC review Wait with merge PRs that shouldn't be merged instantly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants