IBX-9060: Updated StatusCriterionHandler to use in expression for multi-status support
#627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ulti-status support
tbialcz
force-pushed
the
notification-status-criterion-in-operator
branch
from
e9d25aa to
4b56fb3
Compare
ezrobot
requested review from
Steveb-p,
ViniTou,
adamwojs,
alongosz,
barw4,
ciastektk,
konradoboza,
mikadamczyk and
wiewiurdp
and removed request for
a team
|
Steveb-p
approved these changes
Jul 29, 2025
konradoboza
approved these changes
Jul 29, 2025
mikadamczyk
approved these changes
Jul 29, 2025
adamwojs
approved these changes
Jul 30, 2025
Member
|
What scares me a bit is that there's no need to update any tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes an issue where passing both 'read' and 'unread' statuses to the notification search form
resulted in a SQL cardinality error due to use of '=' instead of 'IN'. The criterion handler now uses
expr()->in()andPARAM_INT_ARRAYto support filtering by multiple status values correctly.