IBX-7653: IsContainer criterion added #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tischsoic
force-pushed
the
IBX-7653-images-visible-in-tree-browser-in-image-picker
branch
5 times, most recently
from
a9cf699 to
bdb8ced
Compare
Member
|
@tischsoic You are missing Solr and Elasticsearch counterpart PRs |
Contributor
Author
|
I added solr and elasticsearch support for the |
tischsoic
force-pushed
the
IBX-7653-images-visible-in-tree-browser-in-image-picker
branch
from
d8a24ff to
d394a16
Compare
Steveb-p
reviewed
Apr 4, 2024
src/contracts/Repository/Values/Content/Query/Criterion/IsContainer.php
Outdated
Show resolved
Hide resolved
src/lib/Search/Legacy/Content/Common/Gateway/CriterionHandler/IsContainer.php
Outdated
Show resolved
Hide resolved
tests/integration/Core/Repository/_fixtures/Legacy/IsContainerTrue.php
Outdated
Show resolved
Hide resolved
tests/integration/Core/Repository/_fixtures/Legacy/IsContainerFalse.php
Outdated
Show resolved
Hide resolved
adamwojs
approved these changes
Apr 5, 2024
src/lib/Resources/settings/search_engines/legacy/criterion_handlers_common.yml
Outdated
Show resolved
Hide resolved
Steveb-p
approved these changes
Apr 17, 2024
konradoboza
reviewed
Apr 17, 2024
src/lib/Search/Legacy/Content/Common/Gateway/CriterionHandler/IsContainer.php
Outdated
Show resolved
Hide resolved
konradoboza
approved these changes
Apr 18, 2024
alongosz
reviewed
Apr 18, 2024
Member
There was a problem hiding this comment.
CI is failing here
Seems we have outdated Sonar Cloud exclusion path here https://github.com/ibexa/core/blob/4.6/.sonarcloud.properties.
tischsoic
force-pushed
the
IBX-7653-images-visible-in-tree-browser-in-image-picker
branch
4 times, most recently
from
3f60f79 to
f08c85f
Compare
alongosz
reviewed
Apr 18, 2024
src/lib/Search/Legacy/Content/Common/Gateway/CriterionHandler/IsContainer.php
Outdated
Show resolved
Hide resolved
src/lib/Search/Legacy/Content/Common/Gateway/CriterionHandler/IsContainer.php
Outdated
Show resolved
Hide resolved
tischsoic
force-pushed
the
IBX-7653-images-visible-in-tree-browser-in-image-picker
branch
from
8a9ea73 to
f4b88a0
Compare
This was referenced May 10, 2024
bogusez
approved these changes
May 14, 2024
tischsoic
force-pushed
the
IBX-7653-images-visible-in-tree-browser-in-image-picker
branch
from
f4b88a0 to
cbbfcbf
Compare
tischsoic
force-pushed
the
IBX-7653-images-visible-in-tree-browser-in-image-picker
branch
from
cbbfcbf to
eb52380
Compare
|
dew326
deleted the
IBX-7653-images-visible-in-tree-browser-in-image-picker
branch
Contributor
Author
|
Merged up:
|
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.6Checklist:
$ composer fix-cs).@ibexa/engineering).