IBX-9727: Added type-hints and adapted codebase to PHP8+ #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradoboza
force-pushed
the
introduced-type-hints
branch
2 times, most recently
from
497360a to
9d0d009
Compare
konradoboza
force-pushed
the
introduced-type-hints
branch
5 times, most recently
from
64578b8 to
90da154
Compare
konradoboza
force-pushed
the
introduced-type-hints
branch
from
90da154 to
9ce2513
Compare
konradoboza
changed the title
konradoboza
force-pushed
the
introduced-type-hints
branch
from
92edd84 to
d26cd40
Compare
konradoboza
force-pushed
the
introduced-type-hints
branch
from
d26cd40 to
f45162c
Compare
konradoboza
added a commit
to ibexa/commerce
that referenced
this pull request
Jul 17, 2025
konradoboza
changed the title
konradoboza
force-pushed
the
introduced-type-hints
branch
from
6541a6c to
9f60ec6
Compare
konradoboza
added a commit
to ibexa/commerce
that referenced
this pull request
Jul 18, 2025
konradoboza
force-pushed
the
introduced-type-hints
branch
from
9f60ec6 to
8a44199
Compare
konradoboza
added a commit
to ibexa/commerce
that referenced
this pull request
Jul 18, 2025
konradoboza
force-pushed
the
introduced-type-hints
branch
2 times, most recently
from
28c8666 to
3db4b8b
Compare
konradoboza
force-pushed
the
introduced-type-hints
branch
from
3db4b8b to
1a89f0a
Compare
|
adamwojs
reviewed
Jul 28, 2025
Comment on lines
+27
to
+31
| $uploadMaxFilesize = ini_get('upload_max_filesize'); | ||
| if ($uploadMaxFilesize === false) { | ||
| throw new RuntimeException('Could not retrieve upload_max_filesize from PHP configuration.'); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
This should be inside (!isset($this->value)) {.
| ) | ||
| ->setAutoInitialize(false) | ||
| ->getForm() | ||
| $formConfig->getFormFactory() |
Member
There was a problem hiding this comment.
Suggested change
| $formConfig->getFormFactory() | |
| $formConfig | |
| ->getFormFactory() |
This was referenced Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
nullvalue for content structs inBaseContentTypeadmin-ui#1646nullvalue for content structs inBaseContentTypeuser#114Description:
Regressions: https://github.com/ibexa/commerce/actions/runs/16371114586/job/46554772348 🟢
For QA:
Documentation: