Skip to content

IBX-6636: ezSelection default label 'ALL' is incorrect for NOT multiple choice setting #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 4.6
Choose a base branch
from

Conversation

vidarl
Copy link

@vidarl vidarl commented Nov 13, 2024

🎫 Issue IBX-6636

The text All in the selection placeholder didn't make any sense. Changed it to None

Before change:
image

After change
image

For QA:

  • Create ContentType with ezselection ( multiselection NOT enabled ) with choices
    • BMW
    • Audi
    • Ford
  • Create content with new ContentType and check the placeholder

Copy link

@vidarl vidarl changed the base branch from main to 4.6 November 13, 2024 13:52
@vidarl vidarl requested a review from a team November 13, 2024 14:32
Copy link
Member

@adamwojs adamwojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It definitely make sense for me, but let's double check with @juskora and @NataliaBecla .

@adamwojs adamwojs requested a review from a team February 2, 2025 11:31
@KatarzynaSobczak
Copy link

I would stick to the rule in our Design System but the logic is the same as Radek wrote in the comment of task IBX-6021 - "The usage of "all" as default value in selection/drop-down should depend on the context. General rule: The default label in the selection field should not be "All" if this is not a multiple-choice selection. In practice:

  • dropdown used as a filter should contain ALL, because before selecting a specific value it means that the table displays all possible values (like in JIRA filters) e.g. Status in Orders, Catalogs
  • dropdown used in the selection attribute, currency selector, VAT category should not contain ALL, because you need to select only one value. ALL is not logical in this case."

Long story short:

  • adding 'all' in the dropdown should depend on the context
  • with a single-selection there's no point for 'all'
  • I would stick to the proposed solution of not displaying 'all'

@juskora
Copy link
Contributor

juskora commented Feb 3, 2025

I agree with Kasia, and what's more, for an empty state there should be "Choose an option" not "None" as suggested.

@KatarzynaSobczak
Copy link

@juskora great point!

@vidarl
Copy link
Author

vidarl commented Feb 12, 2025

@juskora, @KatarzynaSobczak

Changing it to "Choose an option" has one disadvantage IMO.

Let's say user as already select something ( in this case "Audi"). Now he wants to unselect it...
User then needs to click on "Choose an option" in order to unselect it:

image

Would it be an idea to label the placeholder "None" if the field is not required, and label it "Choose an option" only of field is required?

@vidarl
Copy link
Author

vidarl commented Mar 10, 2025

ping @juskora, @KatarzynaSobczak

@IdaDraM
Copy link

IdaDraM commented Apr 1, 2025

We discussed issue with naming and behaviour for dropdowns and recommend:

  • For multichoice: Choose an option or All
  • For single select: Choose an option

Each dropdown should have X clear icon, so user can change state to enabled (not filled).
It will be added to Design System.

Designs: https://www.figma.com/design/C84ggnTTrPZa2X0dj23IQ7/Bugs-reported-in-v4.6?node-id=1687-126946&t=ySKCIpUTOGNmIAYE-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants