-
Notifications
You must be signed in to change notification settings - Fork 1
IBX-6636: ezSelection default label 'ALL' is incorrect for NOT multiple choice setting #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.6
Are you sure you want to change the base?
Conversation
…le choice setting
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It definitely make sense for me, but let's double check with @juskora and @NataliaBecla .
I would stick to the rule in our Design System but the logic is the same as Radek wrote in the comment of task IBX-6021 - "The usage of "all" as default value in selection/drop-down should depend on the context. General rule: The default label in the selection field should not be "All" if this is not a multiple-choice selection. In practice:
Long story short:
|
I agree with Kasia, and what's more, for an empty state there should be "Choose an option" not "None" as suggested. |
@juskora great point! |
Changing it to "Choose an option" has one disadvantage IMO. Let's say user as already select something ( in this case "Audi"). Now he wants to unselect it... Would it be an idea to label the placeholder "None" if the field is not required, and label it "Choose an option" only of field is required? |
ping @juskora, @KatarzynaSobczak |
We discussed issue with naming and behaviour for dropdowns and recommend:
Each dropdown should have X clear icon, so user can change state to enabled (not filled). |
The text
All
in the selection placeholder didn't make any sense. Changed it toNone
Before change:

After change

For QA: