IBX-10333 [Behat] Added scenario for hide later coverage #1731

pawlakadrian · 2025-10-01T14:17:00Z

🎫 Issue	IBX-10333

Description:

New scenario for hide later content coverage

For QA:

Documentation:

sonarqubecloud · 2025-10-03T11:20:16Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.6% Duplication on New Code

See analysis details on SonarQube Cloud

pawlakadrian · 2025-10-03T12:39:32Z

Regression:
OSS: ibexa/oss#243 👍
Commerce: ibexa/commerce#1528 👍

tomaszszopinski

Just a few nitpicks :)

tomaszszopinski · 2025-10-06T09:18:38Z

features/standard/ContentManagement.feature

+      | title                  | short_title            | intro            |
+      | TestArticleToHideLater | TestArticleToHideLater | TestArticleIntro |
+    And I'm on Content view Page for "ContentManagement/TestArticleToHideLater"
+    When I perform the "Hide" action


Lets only use When/Then once per scenario. Focus of this scenario should a be a scheduler run.

Sure, fixed.

tomaszszopinski · 2025-10-06T09:18:57Z

features/standard/ContentManagement.feature

+      | title                        | short_title                  | intro            |
+      | TestArticleToCancelHideLater | TestArticleToCancelHideLater | TestArticleIntro |
+    And I'm on Content view Page for "ContentManagement/TestArticleToCancelHideLater"
+    When I perform the "Hide" action


Same as above.

katarzynazawada · 2025-10-06T10:40:19Z

src/lib/Behat/Component/CancelContentDialog.php

+use Ibexa\Behat\Browser\Element\Criterion\ElementTextCriterion;
+use Ibexa\Behat\Browser\Locator\VisibleCSSLocator;
+
+class CancelContentDialog extends Dialog


It seems that Dialog component should be enough here.
This locator https://github.com/ibexa/admin-ui/blob/main/src/lib/Behat/Component/Dialog.php#L35C47-L35C177 covers Cancel scheduled hiding button

Right, working as expected.

…content.

katarzynazawada · 2025-11-20T08:23:37Z

src/bundle/Resources/config/services/test/components.yaml


  Ibexa\AdminUi\Behat\Component\TrashSearch: ~

+  Ibexa\AdminUi\Behat\Component\CancelContentDialog: ~


This is unnecessary after removing CancelContentDialog

Right, I missed that :) Already removed.

sonarqubecloud · 2025-11-20T09:26:56Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.4% Duplication on New Code

See analysis details on SonarQube Cloud

tomaszszopinski

👍
Ive got only one small concern, did you check what time is suggested in 'Hide later'? Usually its 1hr earlier (is by default -1hr or it depends on timezones?), so it works now, but would it be possible for the tests to fail somehow? This is just theoretical rambling from me just to be clear 😉

pawlakadrian · 2025-11-20T14:06:02Z

👍 Ive got only one small concern, did you check what time is suggested in 'Hide later'? Usually its 1hr earlier (is by default -1hr or it depends on timezones?), so it works now, but would it be possible for the tests to fail somehow? This is just theoretical rambling from me just to be clear 😉

I'm not sure that it's depends on timezone, but we can see it's -1hr. To avoid complicating the tests, this can be accepted and the expected result obtained. However, if we wanted to interfere with the dates, we would have to wait for the time to change before moving on, which would prolong the tests. Hope it's ok for you? :)

tomaszszopinski · 2025-11-20T14:11:13Z

Yes, i just worry that the fact that its -1hr is a little too convenient :D

pawlakadrian added the Work in progress label Oct 1, 2025

github-actions bot assigned ciastektk, mikadamczyk and ViniTou Oct 1, 2025

pawlakadrian force-pushed the IBX-10333-hide-later-content branch from 7a50371 to f0aaf3e Compare October 3, 2025 11:18

pawlakadrian added Ready for review and removed Work in progress labels Oct 3, 2025

pawlakadrian requested a review from a team October 3, 2025 12:40

ezrobot requested review from KamilSznajdrowicz, barbaragr, juskora, katarzynazawada, micszo and tomaszszopinski and removed request for a team October 3, 2025 12:40

tomaszszopinski reviewed Oct 6, 2025

View reviewed changes

katarzynazawada requested changes Oct 6, 2025

View reviewed changes

pawlakadrian force-pushed the IBX-10333-hide-later-content branch 2 times, most recently from 4c7194b to 5d86a63 Compare November 18, 2025 12:16

pawlakadrian added Work in progress and removed Ready for review labels Nov 18, 2025

pawlakadrian force-pushed the IBX-10333-hide-later-content branch from da2886f to 12685f2 Compare November 18, 2025 14:47

pawlakadrian added Ready for review and removed Work in progress labels Nov 18, 2025

pawlakadrian changed the title ~~IBX-10333 Added scenario for hide later coverage~~ IBX-10333 [Behat] Added scenario for hide later coverage Nov 19, 2025

pawlakadrian force-pushed the IBX-10333-hide-later-content branch from 202c3ed to e5a5753 Compare November 19, 2025 12:25

pawlakadrian added 2 commits November 20, 2025 09:11

IBX-10333 Added scenario for hide later coverage

e7a206a

IBX-10333 Removed OSS from hide later scenario

1b268e1

pawlakadrian added 3 commits November 20, 2025 09:11

IBX-10333 Added scenario for canceling the schedule for hiding later …

075e840

…content.

Fixes after review

624827e

Restored some parts of code

958619a

pawlakadrian force-pushed the IBX-10333-hide-later-content branch from e5a5753 to 958619a Compare November 20, 2025 08:11

pawlakadrian requested review from katarzynazawada and tomaszszopinski November 20, 2025 08:11

katarzynazawada requested changes Nov 20, 2025

View reviewed changes

Removed unused component

d3af9da

pawlakadrian requested a review from katarzynazawada November 20, 2025 08:51

pawlakadrian added 2 commits November 20, 2025 10:23

Fix line

50f8ec8

Fix line

688403d

katarzynazawada approved these changes Nov 20, 2025

View reviewed changes

KamilSznajdrowicz approved these changes Nov 20, 2025

View reviewed changes

tomaszszopinski approved these changes Nov 20, 2025

View reviewed changes

micszo merged commit 021ad26 into 4.6 Nov 20, 2025
28 checks passed

micszo deleted the IBX-10333-hide-later-content branch November 20, 2025 14:26


		Ibexa\AdminUi\Behat\Component\TrashSearch: ~

		Ibexa\AdminUi\Behat\Component\CancelContentDialog: ~

IBX-10333 [Behat] Added scenario for hide later coverage #1731

IBX-10333 [Behat] Added scenario for hide later coverage #1731

Uh oh!

Conversation

pawlakadrian commented Oct 1, 2025

Description:

For QA:

Documentation:

Uh oh!

sonarqubecloud bot commented Oct 3, 2025

Quality Gate passed

Uh oh!

pawlakadrian commented Oct 3, 2025

Uh oh!

tomaszszopinski left a comment

Choose a reason for hiding this comment

Uh oh!

tomaszszopinski Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

pawlakadrian Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

tomaszszopinski Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

pawlakadrian Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

katarzynazawada Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

pawlakadrian Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

katarzynazawada Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

pawlakadrian Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Nov 20, 2025

Quality Gate passed

Uh oh!

tomaszszopinski left a comment

Choose a reason for hiding this comment

Uh oh!

pawlakadrian commented Nov 20, 2025

Uh oh!

tomaszszopinski commented Nov 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

pawlakadrian Nov 18, 2025 •

edited

Loading