Skip to content

IBX-6680: Disabled add field action in field definition form when translating content type #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 12, 2024
Merged

IBX-6680: Disabled add field action in field definition form when translating content type #1094

merged 3 commits into from
Jan 12, 2024

Conversation

@adamwojs
Copy link
Member

@adamwojs adamwojs commented Jan 5, 2024 •
edited
Loading

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-6680
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? yes
License GPL-2.0

Disabled possibility to add field by clicking on the palette item when content type form is in translation mode.

See also: #1080

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@adamwojs adamwojs requested a review from a team January 5, 2024 07:02
@micszo micszo self-assigned this Jan 10, 2024
@micszo micszo mentioned this pull request Jan 10, 2024
Closed
@Gengar-i Gengar-i requested a review from GrabowskiM January 12, 2024 11:56
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 12, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

micszo
micszo approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on Ibexa Commerce 4.6.0-dev.

@micszo micszo removed their assignment Jan 12, 2024
@adamwojs adamwojs merged commit 5421c82 into main Jan 12, 2024
@adamwojs adamwojs deleted the ibx_6680 branch January 12, 2024 15:13
adamwojs added a commit that referenced this pull request Jan 12, 2024
@adamwojs @Gengar-i
IBX-6680: Disabled add field action in field definition form when tra…
fe66b75 
…nslating content type (#1094)

Co-authored-by: Robert Swoboda <53216935+Gengar-i@users.noreply.github.com>
(cherry picked from commit 5421c82)
@adamwojs adamwojs mentioned this pull request Jan 12, 2024
Merged
5 tasks
adamwojs added a commit that referenced this pull request Jan 15, 2024
@adamwojs @Gengar-i
[Backport] IBX-6680: Disabled add field action in field definition fo…
7bada28 
…rm when translating content type (#1115)

IBX-6680: Disabled add field action in field definition form when translating content type (#1094)

Co-authored-by: Robert Swoboda <53216935+Gengar-i@users.noreply.github.com>
(cherry picked from commit 5421c82)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Steveb-p Steveb-p Steveb-p approved these changes

@dew326 dew326 dew326 approved these changes

@micszo micszo micszo approved these changes

@konradoboza konradoboza konradoboza approved these changes

@GrabowskiM GrabowskiM Awaiting requested review from GrabowskiM

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

Labels

QA approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@adamwojs @Steveb-p @dew326 @micszo @konradoboza @mikadamczyk @Nattfarinn @ciastektk @ViniTou @Gengar-i