This repository was archived by the owner on Aug 12, 2022. It is now read-only.
This repository was archived by the owner on Aug 12, 2022. It is now read-only.
Meeting - 2/6/2019 #2
Closed
Description
Agenda
- Triaging issues
- Improving and documenting our triage and escalation process (@mrmckeb)
- Perhaps setting community SLAs
- Escalation in case of emergencies? Example: "Failed to minify the bundle" error on build (related to Terser) facebook/create-react-app#6334
- Formalize and document the issue triage process (in this repo?)
- Make better use of Projects in GitHub for planning and working through issues and PRs
- Improving and documenting our triage and escalation process (@mrmckeb)
- PRs
- Standardize and document process for reviewing and merging PRs
- Number of required approvals?
- Approvals from code owners?
- Discuss any breaking changes or new features with other maintainers
- Bugfixes, docs updates, refinements to existing features probably don't need consensus
- Standardize and document process for reviewing and merging PRs
- Maintainers
- Make sure we have shared contact info for all maintainers
- Make sure all active maintainers are on Discord
- Write up onboarding documentation and keep in this repo
- Technical
- Project
- Jest is an interesting example
- Facebook Open Source project
- Has its own GitHub org
- Uses Open Collective to raise money
- Pays bounties to users for implementing features
- Jest is an interesting example
Attendees
Notes
- Issues
- Document triaging process in this repo
- If you have questions about an issue post it on Discord
- Use a Project/Milestone to track issues that need further triage
- Projects give you some automation
- PRs
- Document process
- Have at least two approvals for breaking changes and new features
- Discuss breaking changes on Discord
- Use codeowners file
- Maybe make everyone a code owner for
packages
, require one approval- We will need someone from Facebook to enable this setting for us
- Maybe make everyone a code owner for
- Document process
- Maintainers
- Share contact info
- Create an onboarding document in this repo
- Technical
- Config
- Don't want to open up webpack config
- It would be nice to consolidate environment variable config and flags
- Don't want to add a config file or key to
package.json
at this time. Revisit if we start adding more environment variables.
- Templates
- Templates should indicate which version of CRA they are compatible with
- Use peerDependencies
- Talk to popular projects about creating their own templates (redux, storybook, etc.)
- Templates include their own README
- Split our existing templates out into npm packages
- Directory of templates?
- Maybe. Defer until later
- Templates should indicate which version of CRA they are compatible with
- Warn when webpack config is modified
- Freeze the config object and warn if it is changed
- Display a warning in the console if the config is changed
- Direct people to whatever tool they have used to modify it
- Hooks
- Are supported by just using latest version of React
- Need to add ESLint plugin
- This will be a part of 3.0
- 3.0
- Hooks ESLint plugin
- Jest 24
- jsconfig.json?
- Is this ready
- What else?
- Create a Project in GitHub to track
- Config
- Project
- Starting an Open Collective seems like a good idea
- Need to figure out how best to manage this
- Benefits of having our own GitHub org do seem compelling
- Starting an Open Collective seems like a good idea
Previous Action Items
Make this a regular meeting (@iansu)Give maintainers access to this repo (@iansu)Give maintainers access to Netlify (@iansu)- Improve labels
- Add a "Troubleshooting" section to the docs for common install issues
Add additional ignored labels to Stale Bot (@iansu)- Automate docs deploy (@iansu)
- Get Algolia credentials (@iansu)
Action Items
- Improve labels
- Add a "Troubleshooting" section to the docs for common install issues
- Automate docs deploy (@iansu)
- Get Algolia credentials (@iansu)
- Create a shared folder in Google Docs for maintainers (@iansu)
- Document triaging process (@iansu)
- Document PR process (@iansu)
- Create maintainer onboarding document (@iansu)
- Try to get a hold of Jack (@bugzpodder) and get him back on Discord (@Timer)
- Prototype template behaviour with dependencies, etc. (@mrmckeb)
- Create a GitHub Project for 3.0 (@iansu)
- Create a GitHub Project for issue triaging (@iansu)
- Prototype webpack config freezing/warning (@Timer)
- Set up CODEOWNERS (@iansu)
Details
February 6, 2019 10:00am Pacific
https://www.timeanddate.com/worldclock/fixedtime.html?msg=Create+React+App+maintainers+meeting&iso=20190206T18&p1=1440
Metadata
Metadata
Assignees
Labels
No labels