Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added import using wildcard to docs #391

Merged
merged 3 commits into from
Jun 20, 2020

Conversation

thesunny
Copy link
Collaborator

As per #377

With respect to the documentation, I import the wildcard as be which is what my library was called but the reason is that it is fairly descriptive. e.g. be.optional(be.string()). It also doesn't conflict with other methods like is.

However, that's a personal choice. I can change it to something else like ss so we'd end up with ss.optional(ss.string()).

@ianstormtaylor
Copy link
Owner

Thank you @thesunny! I just changed it to s for now so that the docs aren't too opinionated on it, but you're right that folks can choose whatever name like best.

@ianstormtaylor ianstormtaylor merged commit 4cdb8ad into ianstormtaylor:master Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants