-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NodeNext Compat #1224
NodeNext Compat #1224
Conversation
This fixes compat with TypeScript's NodeNext module resolution.
I'm happy to say that this worked perfectly with Superforms, so I'm ready to add it to the library. Will it be a big change for the next official version, or can I add it already with the pre-release version? |
Hello again @arturmuller, any progress on this one? It would be very nice to support another library for Superforms. |
Hey @arturmuller what do you think? |
This could be rebased onto main now that the tests are running on something newer! |
It seems like the prettier API has changed and it is no longer possible to combine --list-different and --write.
The goal of this PR is to fix Superstruct's compatibility with TypeScript's NodeNext module / module resolution settings. The simplest fix I could think of (and which was also proposed in #1211 by @ciscoheat) is to add file extensions to imports. This is currently in the PR, however, this presents several issues:
.js
not.ts
(since TS doesn't rewrite paths), and we lose directory import. Bottom line, this feels like a non-ideal way to do this and other libs manage in a more elegant way, so we investigate how this can be done.